Skip to content

Commit

Permalink
Explain changelog in developer docs (#57)
Browse files Browse the repository at this point in the history
  • Loading branch information
maxschulz-COL authored Sep 25, 2023
1 parent db052c6 commit 4bd9b0e
Show file tree
Hide file tree
Showing 6 changed files with 110 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug-report.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Bug report
description: Something is not working correctly.
description: Something is not working correctly
labels: "Status: Needs triage :mag:, Issue: Bug Report :bug:"

body:
Expand Down
52 changes: 52 additions & 0 deletions .github/ISSUE_TEMPLATE/general-question.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
name: General question
description: General questions around Vizro
labels: "Status: Needs triage :mag:, Issue: General Question :question:"

body:
- type: markdown
attributes:
value: >-
Hi there! Thank you so much for taking the time to fill in this question form. It will be
a valuable contribution to Vizro.
We'd appreciate it if you could search on Vizro's existing issues prior to filing
a general question to avoid any duplicate tickets, as we have limited maintainer capacity to triage
them. Thanks!
- type: textarea
attributes:
label: Question
description: >-
Please post your question here.
validations:
required: true

- type: textarea
attributes:
label: Code/Examples
description: >-
Please post any supporting code around your question here.
- type: textarea
attributes:
label: Other information
description: >-
Please provide any attempts on answering the question, or any related information you already found here.
- type: input
attributes:
label: vizro version
- type: input
attributes:
label: Python version
- type: input
attributes:
label: OS

- type: checkboxes
attributes:
label: Code of Conduct
options:
- label: >-
I agree to follow the [Code of Conduct](https://github.com/mckinsey/vizro/blob/main/CODE_OF_CONDUCT.md).
required: true
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ Rapidly self-serve the assembly of customised dashboards in minutes - without th
<img src="https://raw.githubusercontent.com/mckinsey/vizro/main/.github/images/code_dashboard.png" width="1300"/>
</p>

Use a few lines of simple configuration to create complex dashboards, which are automatically assembled utilising libraries such as **Plotly** and **Dash**, with inbuilt coding and design best practices
Use a few lines of simple configuration to create complex dashboards, which are automatically assembled utilising libraries such as [**Plotly**](https://github.com/plotly/plotly.py) and [**Dash**](https://github.com/plotly/dash), with inbuilt coding and design best practices

Define high level categories within the configuration, including:

Expand Down Expand Up @@ -121,7 +121,7 @@ See the [Documentation](https://vizro.readthedocs.io/en/latest/) for more detail

## Community and Development

We encourage you to ask and answer technical questions via the [GitHub Issues](https://github.com/mckinsey/vizro/issues)
We encourage you to ask and answer technical questions via the [GitHub Issues](https://github.com/mckinsey/vizro/issues). This is also the place where you can submit bug reports or request new features.

## Contributing

Expand Down
4 changes: 2 additions & 2 deletions vizro-core/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ Rapidly self-serve the assembly of customised dashboards in minutes - without th
<img src="https://raw.githubusercontent.com/mckinsey/vizro/main/.github/images/code_dashboard.png" width="1300"/>
</p>

Use a few lines of simple configuration to create complex dashboards, which are automatically assembled utilising libraries such as **Plotly** and **Dash**, with inbuilt coding and design best practices
Use a few lines of simple configuration to create complex dashboards, which are automatically assembled utilising libraries such as [**Plotly**](https://github.com/plotly/plotly.py) and [**Dash**](https://github.com/plotly/dash), with inbuilt coding and design best practices

Define high level categories within the configuration, including:

Expand Down Expand Up @@ -121,7 +121,7 @@ See the [Documentation](https://vizro.readthedocs.io/en/latest/) for more detail

## Community and Development

We encourage you to ask and answer technical questions via the [GitHub Issues](https://github.com/mckinsey/vizro/issues)
We encourage you to ask and answer technical questions via the [GitHub Issues](https://github.com/mckinsey/vizro/issues). This is also the place where you can submit bug reports or request new features.

## Contributing

Expand Down
42 changes: 42 additions & 0 deletions vizro-core/changelog.d/20230925_102333_maximilian_schulz_1073.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
<!--
A new scriv changelog fragment.
Uncomment the section that is right (remove the HTML comment wrapper).
-->

<!--
### Removed
- A bullet item for the Removed category.
-->
<!--
### Added
- A bullet item for the Added category.
-->
<!--
### Changed
- A bullet item for the Changed category.
-->
<!--
### Deprecated
- A bullet item for the Deprecated category.
-->
<!--
### Fixed
- A bullet item for the Fixed category.
-->
<!--
### Security
- A bullet item for the Security category.
-->
15 changes: 11 additions & 4 deletions vizro-core/docs/pages/development/contributing.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,18 @@
## Contributing guidelines

Contributions of all experience levels are welcome! There are many ways to contribute, and we appreciate all of them. We are still defining a detailed process, but for the time being, please use our [issues page](https://github.com/mckinsey/vizro/issues) to discuss any contributions.
Contributions of all experience levels are welcome! There are many ways to contribute, and we appreciate all of them. Please use our [issues page](https://github.com/mckinsey/vizro/issues) to discuss any contributions.

### Found a bug

Great! We would appreciate if you could head to our [issues page](https://github.com/mckinsey/vizro/issues) and raise a ticket in the category `bug report`. We would appreciate if you searched the existing issues for a similar description before raising a new ticket. We will try to reproduce your reported bug as soon as possible before getting back to you on next steps.
Great! We would appreciate if you could head to our [issues page](https://github.com/mckinsey/vizro/issues) and raise a ticket in the category `bug report`. It would greatly assist us if you could first check if there are any existing issues with a similar description before submitting a new ticket. We will promptly work on reproducing the bug you've reported and will follow up with the next steps.

### Request a feature

Splendid! In order to raise a feature request, please head to our [issues page](https://github.com/mckinsey/vizro/issues) and raise a ticket in the category `feature request`. We would appreciate if you searched the existing issues for a similar description before raising a new ticket. We will get back to you as soon as possible with an estimate of whether and when this feature could be released.
Splendid! In order to raise a feature request, please head to our [issues page](https://github.com/mckinsey/vizro/issues) and raise a ticket in the category `feature request`. We would appreciate if you searched the existing issues for a similar description before raising a new ticket. The team will then try to understand the request in more detail, explore the feasibility and prioritize it in relation to the current roadmap. We will get back to you as soon as possible with an estimate of whether and when this feature could be released.

### General question

Nice! We are happy to receive general questions around Vizro. Please head to our [issues page](https://github.com/mckinsey/vizro/issues) and raise a ticket in the category `general question`. We would be grateful if you could check for any similar descriptions in the existing issues before opening a new ticket.

## How to interact with the repository

Expand Down Expand Up @@ -128,6 +132,9 @@ adding or removing dependencies.

## Changelog

Vizro keeps a changelog, where all notable changes to the project will be documented. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

Vizro uses [scriv](https://pypi.org/project/scriv/) to build and maintain a meaningful `CHANGELOG.md`. When creating a PR, the developer needs to ensure that
a changelog fragment has been created in the folder `changelog.d`. This fragment is a small `.md` file describing the changes of the current PR that should be mentioned in the `CHANGELOG.md` entry of the next release.

Expand All @@ -137,7 +144,7 @@ You can easily create such a fragment by running
hatch run docs:changelog
```

and then uncommenting the relevant section(s) you want to describe. In case your PR does not contain `CHANGELOG.md` relevant changes, leave everything commented out.
Please begin by uncommenting the relevant section(s) you wish to describe. If your PR includes changes that are not relevant to `CHANGELOG.md`, please leave everything commented out. If you are uncertain about what to add or whether to add anything, please refer to [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). The rule of thumb should be, if in doubt, or if the user is affected in any way, it should be described in the `CHANGELOG.md`.

## Releases

Expand Down

0 comments on commit 4bd9b0e

Please sign in to comment.