Skip to content

Commit

Permalink
A few small comments
Browse files Browse the repository at this point in the history
  • Loading branch information
antonymilne committed Oct 24, 2023
1 parent e3f1a31 commit 1aebc87
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 12 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/check-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -118,3 +118,7 @@ jobs:
./../tools/version-bump.sh mckinsey vizro ${{ secrets.GITHUB_TOKEN }} \
${{needs.check-version.outputs.package_name}} \
${{needs.check-version.outputs.package_version}} release/version_bump_next_minor/${formatted_date}
# automate merging of this?
# why need lint here?
# does github release notes automatically? Why not scriv github-release?
7 changes: 2 additions & 5 deletions .github/workflows/lint-vizro-core.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
steps:
- uses: actions/checkout@v4
with:
fetch-depth: ${{ github.event_name == 'pull_request' && 2 || 0 }}
fetch-depth: ${{ github.event_name == 'pull_request' && 2 || 0 }} #why?

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
Expand All @@ -50,14 +50,11 @@ jobs:
run: hatch run all.py${{ matrix.python-version }}:schema --check

- name: Check requirements for Snyk are up to date
run: |
pwd
hatch run all.py${{ matrix.python-version }}:update-snyk-requirements --check
run: hatch run all.py${{ matrix.python-version }}:update-snyk-requirements --check

- name: Find added changelog fragments
id: added-files
run: |
pwd
if ${{ github.event_name == 'pull_request' }}; then
echo "added_files=$(git diff --name-only --diff-filter=A -r HEAD^1 HEAD -- changelog.d/*.md | xargs)" >> $GITHUB_OUTPUT
else
Expand Down
13 changes: 6 additions & 7 deletions vizro-core/hatch.toml
Original file line number Diff line number Diff line change
Expand Up @@ -40,16 +40,15 @@ lint = "SKIP=gitleaks pre-commit run {args} --all-files"
post-release = [
"hatch version patch,dev",
"echo 'Raise a PR to bump to the new development version'"
] # can it be automated?
] # No longer needed?

prep-release = [
"hatch version release",
"git checkout -b release/vizro-core/$(hatch version) origin/main",
#"hatch run changelog:scriv collect --add",
# "rm -rf schemas/*json",
# "schema",
# "hatch run lint || hatch run lint", #why?
# "hatch run changelog:add",
"hatch run changelog:scriv collect --add",
"rm -rf schemas/*json",
"schema",
"hatch run lint || hatch run lint",
"hatch run changelog:add",
'echo "Now raise a PR to merge into main with title: Release of vizro-core $(hatch version)"',
]
pypath = "python -c 'import sys; print(sys.executable)'"
Expand Down

0 comments on commit 1aebc87

Please sign in to comment.