Let ListAction skip pull requests having no binary data #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. Is this effectively a duplicate of #796? One thing I'm still missing from this is replication steps: not having part of the data on a pull request seems like an invalid scenario we should be preventing elsewhere, rather than attempting to return a response that technically isn't valid for one of the APIs |
|
I'm superceding this with #847 since the Pull Request data fields are not mandatory and I'd rather we didn't end up with data in the database that wasn't visible in the API, as users then don't know if they've got potentially broken data needing cleaned-up. Thanks for the contribution though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #759 (comment), this change lets
ListActionskip pull requests without binary data.