Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uptime to SNMP traps to prevent replay attack #219

Merged
merged 11 commits into from
Jan 26, 2025
Merged

Add uptime to SNMP traps to prevent replay attack #219

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
af4e7de
Allowing to set a custom base OID for trap sub-objects
vigno99 Apr 24, 2023
6701248
Removed "Enabled" parameter
vigno99 Apr 25, 2023
33b0931
Update unit tests with new parameter
vigno99 Apr 25, 2023
a5fb0df
Updated readme
vigno99 Apr 25, 2023
3f89947
Fix the http server unit test
vigno99 Apr 25, 2023
11fd3b8
Do not append .1 to the trap OID
vigno99 Apr 25, 2023
b5f3e72
Rename custom-base-oid-sub-object to sub-object-default-oid
vigno99 Nov 24, 2023
fbeaae9
Merge branch 'main' into main
vigno88 Nov 24, 2023
1b4d1fd
tes
vigno88 Jan 17, 2025
1b5bf5e
With boots time
vigno88 Jan 17, 2025
37efb33
Merge branch 'main' of github.com:vigno88/snmp_notifier
vigno88 Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions trapsender/trap_sender.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ package trapsender

import (
"errors"
"math"
"strings"
"time"

Expand Down Expand Up @@ -114,10 +115,14 @@ func (trapSender TrapSender) sendTraps(connectionArguments snmpgo.SNMPArguments,
snmp.Close()
}()

hasError := false
uptime, _ := host.Uptime()
if uptime > math.MaxInt32 {
uptime = 0
}

hasError := false
for _, trap := range traps {
err = snmp.V2Trap(trap)
err = snmp.V2TrapWithBootsTime(trap, 0, int(uptime))
if err != nil {
telemetry.SNMPTrapTotal.WithLabelValues(distinationForMetrics, "failure").Inc()
level.Error(*trapSender.logger).Log("msg", "error while generating trap", "destination", distinationForMetrics, "err", err)
Expand Down