Add uptime to SNMP traps to prevent replay attack (#219)

* Allowing to set a custom base OID for trap sub-objects * Removed "Enabled" parameter * Update unit tests with new parameter * Updated readme * Fix the http server unit test * Do not append .1 to the trap OID * Rename custom-base-oid-sub-object to sub-object-default-oid * tes * With boots time --------- Co-authored-by: nalixvignola <[email protected]>
maxwo · Jan 26, 2025 · 0c29e84 · 0c29e84
1 parent 8621de1
commit 0c29e84
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/trapsender/trap_sender.go b/trapsender/trap_sender.go
@@ -15,6 +15,7 @@ package trapsender
 
 import (
 	"errors"
+	"math"
 	"strings"
 	"time"
 
@@ -114,10 +115,14 @@ func (trapSender TrapSender) sendTraps(connectionArguments snmpgo.SNMPArguments,
 		snmp.Close()
 	}()
 
-	hasError := false
+	uptime, _ := host.Uptime()
+	if uptime > math.MaxInt32 {
+		uptime = 0
+	}
 
+	hasError := false
 	for _, trap := range traps {
-		err = snmp.V2Trap(trap)
+		err = snmp.V2TrapWithBootsTime(trap, 0, int(uptime))
 		if err != nil {
 			telemetry.SNMPTrapTotal.WithLabelValues(distinationForMetrics, "failure").Inc()
 			level.Error(*trapSender.logger).Log("msg", "error while generating trap", "destination", distinationForMetrics, "err", err)