Skip to content

Commit

Permalink
Merge pull request #354 from maxfordham/353-editgrid-kwargs-bug
Browse files Browse the repository at this point in the history
🐛 EditGrid: Only pass necessary kwargs
  • Loading branch information
ollyhensby authored Jan 13, 2025
2 parents 92107ee + 25c56e7 commit 72f5064
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions src/ipyautoui/custom/editgrid.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@

from ipyautoui.autoobject import AutoObjectForm
from ipyautoui.custom.buttonbars import CrudButtonBar
from ipyautoui._utils import frozenmap
from ipyautoui._utils import frozenmap, traits_in_kwargs
from ipyautoui.constants import BUTTON_WIDTH_MIN
from ipyautoui.custom.autogrid import AutoGrid
from ipyautoui.custom.title_description import TitleDescription
Expand Down Expand Up @@ -336,9 +336,13 @@ def __init__(
self._init_form()
self._init_row_controls()
self._init_controls()
# NOTE: setting kwargs here and in _init_autogrid may cause unwanted behaviour
# PR: https://github.com/maxfordham/ipyautoui/pull/351
super().__init__(**kwargs)
super().__init__(
**{
k: v
for k, v in kwargs.items()
if k not in traits_in_kwargs(AutoGrid, kwargs)
}
) # NOTE: Only pass kwargs not in AutoGrid traits
self.warn_on_delete = warn_on_delete
# self.show_copy_dialogue = show_copy_dialogue
self.show_copy_dialogue = False
Expand Down

0 comments on commit 72f5064

Please sign in to comment.