consolidate service configuration #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously a separate `CookieConfig` was used. However, this configuration scope extends beyond the cookie and includes e.g. the session expiry. In fact, the proper scope for this configuration is either the session or the service. The session does not need to be coupled to how it might be represented, i.e. as a cookie, so here we move those concerns onto the service. The config is still contained within its own type, to make it easier to operate over within the middleware.
Codecov Report
@@ Coverage Diff @@
## main #67 +/- ##
==========================================
+ Coverage 64.92% 65.03% +0.11%
==========================================
Files 14 13 -1
Lines 573 572 -1
==========================================
Hits 372 372
+ Misses 201 200 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a separate
CookieConfigwas used. However, this configuration scope extends beyond the cookie and includes e.g. the session expiry. In fact, the proper scope for this configuration is either the session or the service. The session does not need to be coupled to how it might be represented, i.e. as a cookie, so here we move those concerns onto the service. The config is still contained within its own type, to make it easier to operate over within the middleware.