Fix the update strategy for the diesel store to work with all backends #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiznich
force-pushed
the
session-prefix
branch
from
45c8c3c to
e6be4c7
Compare
This commit just queries the table first to decide whether an insert or an update statement is required.
weiznich
force-pushed
the
session-prefix
branch
from
e6be4c7 to
6470843
Compare
Codecov Report
@@ Coverage Diff @@
## session-prefix #64 +/- ##
=================================================
Coverage ? 80.03%
=================================================
Files ? 14
Lines ? 571
Branches ? 0
=================================================
Hits ? 457
Misses ? 114
Partials ? 0 |
|
GH automatically closed this PR when I merged #62. That doesn't seem right, so if there's some repo config that needs to be updated to prevent that in the future please let me know and I'll fix that from happening in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by querying the table to check if the session is already there and then issue an insert/update statement as required.