cpp: only enable Wall and others for GCC

Windows uses different flags.
mavlink · Apr 29, 2024 · 159f83e · 159f83e
1 parent 8d5c446
commit 159f83e
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 24 deletions.
diff --git a/libs/cpp/parse/CMakeLists.txt b/libs/cpp/parse/CMakeLists.txt
@@ -3,14 +3,17 @@ include(GNUInstallDirs)
 add_library(libevents_parser
 	parser.cpp
 )
-target_compile_options(libevents_parser
-	PRIVATE
-	-Wall
-	-Wextra
-	-Werror
-	-Wconversion
-	-Wpedantic
-)
+
+if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
+	target_compile_options(libevents_parser
+		PRIVATE
+		-Wall
+		-Wextra
+		-Werror
+		-Wconversion
+		-Wpedantic
+	)
+endif()
 set_target_properties(libevents_parser PROPERTIES PUBLIC_HEADER parser.h)
 install(TARGETS libevents_parser
 		EXPORT libevents
@@ -31,14 +34,16 @@ install(TARGETS nlohmann_json
 add_library(libevents_health_and_arming_checks
 	health_and_arming_checks.cpp
 )
-target_compile_options(libevents_health_and_arming_checks
-	PRIVATE
-	-Wall
-	-Wextra
-	-Werror
-	-Wconversion
-	-Wpedantic
-)
+if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
+	target_compile_options(libevents_health_and_arming_checks
+		PRIVATE
+		-Wall
+		-Wextra
+		-Werror
+		-Wconversion
+		-Wpedantic
+	)
+endif()
 set_target_properties(libevents_health_and_arming_checks PROPERTIES PUBLIC_HEADER health_and_arming_checks.h)
 install(TARGETS libevents_health_and_arming_checks
 		EXPORT libevents

diff --git a/libs/cpp/tests/CMakeLists.txt b/libs/cpp/tests/CMakeLists.txt
@@ -33,14 +33,16 @@ add_custom_target(libevents_test_header DEPENDS ${generated_events_header})
 add_executable(parser_test
 	parser.cpp
 )
-target_compile_options(parser_test
-	PRIVATE
-	-Wall
-	-Wextra
-	-Werror
-	-Wconversion
-	-Wpedantic
-)
+if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
+	target_compile_options(parser_test
+		PRIVATE
+		-Wall
+		-Wextra
+		-Werror
+		-Wconversion
+		-Wpedantic
+	)
+endif()
 target_link_libraries(parser_test PRIVATE
 	libevents_parser
 	GTest::gtest_main