Roll to Chromium 129.0.6632.1 (r1336433) #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Havunen
commented
Aug 2, 2024
| @@ -1007,14 +1007,12 @@ pub(crate) fn generate_field_name(name: &str) -> String { | |||
| } | |||
| } | |||
|
|
|||
| /// Escapes reserved rust keywords | |||
| pub(crate) fn generate_type_name(name: &str) -> String { | |||
| let name = name.to_upper_camel_case(); | |||
There was a problem hiding this comment.
This was some non-sense copy paste from the above method. "to upper camelcase" -> "lowercase match"
Havunen
commented
Aug 2, 2024
| "override" => "r#override".to_string(), | ||
| _ => name, | ||
| pub(crate) fn generate_enum_field_name(name: &str) -> String { | ||
| match name { |
There was a problem hiding this comment.
There was new enum with identifier "Self" which does not compile in Rust so renamed it to "KSelf"
|
Need to fix the build errors still |
Havunen
commented
Aug 3, 2024
| @@ -480,9 +485,9 @@ impl FrameManager { | |||
|
|
|||
| /// Issued when execution context is destroyed | |||
| pub fn on_frame_execution_context_destroyed(&mut self, event: &EventExecutionContextDestroyed) { | |||
| if let Some(id) = self.context_ids.remove(&event.execution_context_id) { | |||
| if let Some(id) = self.context_ids.remove(&event.execution_context_unique_id) { | |||
There was a problem hiding this comment.
EventExecutionContextDestroyed.event.execution_context_id is deprecated
|
@mattsse Can you review please |
Havunen
commented
Aug 3, 2024
| @@ -61,6 +61,7 @@ async-std-runtime = ["async-std", "async-tungstenite/async-std-runtime"] | |||
| tokio-runtime = ["tokio", "async-tungstenite/tokio-runtime"] | |||
| fetcher = [] | |||
| bytes = ["dep:bytes"] | |||
| serde0 = [] | |||
There was a problem hiding this comment.
I added serde0 as feature because there were config attributes checking for feature named "serde0" but it was not defined and clippy was complaining about it
There was a problem hiding this comment.
|
@mattsse Could this be merged please, I need the new APIs |
mattsse
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #229