feat(browser): add support for the new headless mode in BrowserConfig #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Feb 15, 2024
src/browser.rs
Outdated
Comment on lines
562
to
570
| #[derive(Debug, Clone)] | ||
| enum HeadlessMode { | ||
| False, | ||
| True, | ||
| New, | ||
| } |
There was a problem hiding this comment.
Hi @mattsse sure and it's now added. Sorry for not having included any description from the start.
starrify
force-pushed
the
browser-config-add-new-headless-mode
branch
from
f95b254 to
dda6fff
Compare
mattsse
requested changes
Feb 18, 2024
| /// The "headful" mode. | ||
| False, | ||
| /// The old headless mode (default). | ||
| True, |
src/browser.rs
Outdated
Comment on lines
698
to
706
| pub fn with_head(mut self) -> Self { | ||
| self.headless = false; | ||
| self.headless = HeadlessMode::False; | ||
| self | ||
| } | ||
|
|
||
| pub fn new_headless_mode(mut self) -> Self { | ||
| self.headless = HeadlessMode::New; | ||
| self | ||
| } |
There was a problem hiding this comment.
we want a new function that provides the HeadlessMode as argument
src/browser.rs
Outdated
| @@ -559,11 +559,21 @@ async fn ws_url_from_output( | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Debug, Clone)] | |||
There was a problem hiding this comment.
Suggested change
| #[derive(Debug, Clone)] | |
| #[derive(Debug, Clone, Copy, Default, PartialEq, Eq)] |
|
Hi @mattsse , thanks a lot for the recommendations! I have the request changes applied accordingly. |
mattsse
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #183 (kind of)