Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the fetcher revision API #193

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Improve the fetcher revision API #193

merged 3 commits into from
Dec 14, 2023

Conversation

MOZGIII
Copy link
Contributor

@MOZGIII MOZGIII commented Dec 8, 2023 •
edited
Loading

It would also be nice to implement the platform parsing from string, please tell me what you think about it.

@MOZGIII MOZGIII changed the title Improve the fetcher API Improve the fetcher revision API Dec 8, 2023
mattsse
mattsse requested changes Dec 11, 2023
View reviewed changes
Copy link
Owner

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is better, yes.

the breaking change is likely negligible, but mind adding a #[from] here:

chromiumoxide/chromiumoxide_fetcher/src/error.rs

Line 10 in 190fbb2

InvalidRevision(#[source] ParseIntError),

@MOZGIII
Copy link
Contributor Author

MOZGIII commented Dec 12, 2023

I'd argue against since because not every ParseIntError is necessarily a InvalidRevision by definition. It is coincidentally true now, but I don't think we'd want this in the API in a way that looks intentional.

@mattsse
Copy link
Owner

mattsse commented Dec 14, 2023

reasonable

@mattsse mattsse merged commit 479ff67 into mattsse:main Dec 14, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MOZGIII @mattsse