Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add capture_beyond_viewport to ScreenshotParamsBuilder #192

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Add capture_beyond_viewport to ScreenshotParamsBuilder #192

merged 1 commit into from
Nov 21, 2023

Conversation

T4rp
Copy link
Contributor

@T4rp T4rp commented Nov 20, 2023

My first pull request
roast me

mattsse
mattsse approved these changes Nov 21, 2023
View reviewed changes
Copy link
Owner

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

no need for that :) this lgtm

@mattsse mattsse merged commit 190fbb2 into mattsse:main Nov 21, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@T4rp @mattsse