#25168 Microsoft Calendar O365 README > Split out admin content to child pages #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #344 +/- ##
=======================================
Coverage 23.71% 23.71%
=======================================
Files 62 62
Lines 3087 3087
=======================================
Hits 732 732
Misses 2274 2274
Partials 81 81 ☔ View full report in Codecov by Sentry. |
mickmister
reviewed
Nov 9, 2023
There was a problem hiding this comment.
Thanks @Reene-Simon! Just a couple minor suggestions. Otherwise LGTM!
Co-authored-by: Michael Kochell <[email protected]>
|
@cwarnermm @mickmister all the changes have been made. Please do review it. |
mickmister
approved these changes
Nov 9, 2023
|
@hanzei There is a similar lint issue here too like mattermost-community/mattermost-plugin-bitbucket#127 (comment) |
cwarnermm
added
the
4: Reviews Complete
|
@Reene-Simon We are in the process of resolving a linting issue in our CI pipeline. We can merge once this is fixed |
|
@mickmister yeah sure no worries! |
|
Thanks @Reene-Simon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR organizes the README section as per the instructions in the issue description. I have used the reviews given for a similar issue, namely the Bitbucket README and have tried to incorporate the instructions given by the reviewers. Hence, I haven't relinked the images as per given in the ticket. If this step is necessary, do let me know and I'll make the required changes. These are the main changes that have been done:
Ticket Link
Fixes mattermost/mattermost#25168