Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update community supported README: legal disclaimer #343

Merged
merged 6 commits into from
Jan 5, 2024
Merged

Update community supported README: legal disclaimer #343

merged 6 commits into from
Jan 5, 2024

Conversation

cwarnermm
Copy link
Member

Added legal disclaimer to README, as requested by Product.

@cwarnermm cwarnermm added the 2: Dev Review Requires review by a core committer label Nov 1, 2023
@cwarnermm cwarnermm requested review from larkox and hanzei November 1, 2023 15:36
@cwarnermm cwarnermm requested a review from mickmister as a code owner November 1, 2023 15:36
@cwarnermm
Copy link
Member Author

@larkox - Please confirm whether or not you'd prefer to remain listed as a maintainer of this repository. Happy to update this PR as needed.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (65b2e67) 23.71% compared to head (68fedef) 23.71%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #343   +/-   ##
=======================================
  Coverage   23.71%   23.71%           
=======================================
  Files          62       62           
  Lines        3087     3087           
=======================================
  Hits          732      732           
  Misses       2274     2274           
  Partials       81       81

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hanzei
hanzei requested changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until the discussion in https://community.mattermost.com/private-core/pl/51hbdxfn7tbbuboys4siw8peea has been resolved

cwarnermm
cwarnermm commented Dec 8, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@cwarnermm cwarnermm requested a review from hanzei December 8, 2023 15:49
@cwarnermm
Copy link
Member Author

@hanzei - Legal's updated guidance and language for the legal disclaimer for community-supported integrations has been applied to this PR.

@cwarnermm cwarnermm added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Dec 12, 2023
@cwarnermm cwarnermm enabled auto-merge (squash) December 12, 2023 18:34
@cwarnermm
Copy link
Member Author

@hanzei - This PR is ready for your final approval.

1 similar comment
@cwarnermm
Copy link
Member Author

@hanzei - This PR is ready for your final approval.

@cwarnermm cwarnermm merged commit de2e85a into master Jan 5, 2024
2 checks passed
@cwarnermm cwarnermm deleted the mscalendar-legal branch January 5, 2024 08:30
@raghavaggarwal2308 raghavaggarwal2308 added this to the v1.3.0 milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkox larkox larkox approved these changes

@mickmister mickmister mickmister approved these changes

@hanzei hanzei hanzei approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
6 participants
@cwarnermm @codecov-commenter @larkox @mickmister @hanzei @raghavaggarwal2308