Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the issue with "AtlassianSecurityContext" being nil after migration to oauth #1002

Merged
merged 10 commits into from
Dec 4, 2023
Merged

Fix the issue with "AtlassianSecurityContext" being nil after migration to oauth #1002

merged 10 commits into from
Dec 4, 2023

Conversation

mickmister
Copy link
Contributor

@mickmister mickmister commented Nov 22, 2023 •
edited
Loading

Summary

This PR is a continuation of #999

Tests are added for most relevant permutations of instance type installations, instance migration, and user connection status.

Ticket Link

Fixes #1001

@mickmister mickmister changed the title Cloud oauth migration unit test Fix the issue with "AtlassianSecurityContext" being nil after migration to oauth Nov 22, 2023
@mickmister mickmister mentioned this pull request Nov 22, 2023
Closed
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023 •
edited
Loading

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (06a02e8) 29.48% compared to head (1bd19ff) 33.15%.
Report is 4 commits behind head on master.

❗ Current head 1bd19ff differs from pull request most recent head 1b40745. Consider uploading reports for the commit 1b40745 to get more accurate results

Files Patch % Lines
server/mock_kv_store.go 68.00% 6 Missing and 2 partials ⚠️
server/kv.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1002      +/-   ##
==========================================
+ Coverage   29.48%   33.15%   +3.67%     
==========================================
  Files          52       53       +1     
  Lines        7848     7890      +42     
==========================================
+ Hits         2314     2616     +302     
+ Misses       5337     5048     -289     
- Partials      197      226      +29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

raghavaggarwal2308
raghavaggarwal2308 approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@raghavaggarwal2308 raghavaggarwal2308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mickmister LGTM, just added a few comments.

server/instance_cloud_oauth_migration_test.go Show resolved Hide resolved
server/kv.go Show resolved Hide resolved
@mickmister mickmister requested a review from hanzei November 30, 2023 16:30
hanzei
hanzei approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on the tests 👍

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Dec 1, 2023
@mickmister mickmister merged commit 8372a0c into master Dec 4, 2023
7 checks passed
@mickmister mickmister deleted the cloud-oauth-migration-unit-test branch December 4, 2023 17:08
@mickmister mickmister added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Dec 4, 2023
@mickmister mickmister mentioned this pull request Dec 20, 2023
Merged
@avas27JTG avas27JTG added this to the v4.1.0 milestone Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanzei hanzei hanzei approved these changes

@raghavaggarwal2308 raghavaggarwal2308 raghavaggarwal2308 approved these changes

@avas27JTG avas27JTG Awaiting requested review from avas27JTG

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v4.1.0
Development

Successfully merging this pull request may close these issues.

Fix the issue with "AtlassianSecurityContext" being nil after migration to oauth
5 participants
@mickmister @codecov-commenter @hanzei @raghavaggarwal2308 @avas27JTG