Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes of the early results from the second OZ audit #266

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fixes of the early results from the second OZ audit #266

wants to merge 7 commits into from
+14 −11

Conversation

jcsec-security
Copy link
Collaborator

Description

Issue fixing of the initial audit results shared last week:

  • M-01: still in discussion @ly0va
  • L-01: proposed fix in this PR
  • L-02: proposed fix in this PR
  • N-01: proposed fix in this PR
  • N-02: proposed fix in this PR
  • N-03: pending, I prefer not to reorganize dependencies myself
  • N-04: proposed fix in this PR
  • N-05: already fixed in PR262

Additional context

@jcsec-security
Copy link
Collaborator Author

Let me know if the address conversion steps that I took on src/libraries/SessionLib.sol are correct

cpb8010
cpb8010 approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@cpb8010 cpb8010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra checks make sense to me and the tests pass, so it should still work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpb8010 cpb8010 cpb8010 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcsec-security @cpb8010