Update module install and remove interfaces #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modules no longer have any permission to act on the account, so any disabling will need to come from the account, removing the last use case for disable. Init was functionality duplicated with the add key functionality, so it was removed in favor of the existing interface.
Publishes the domain since that's useful vs the raw bytes which is hard
conflict with removing init after removing events
The revert if exists functionality moves to the account Also the disable functions are removed again
|
Lyova and I chatted about adding back the empty onInstall/onUninstall interfaces just in case there's some unique set up / tear down that modules want to perform outside of validation key setup |
Adds a new entry point so we can remove modules
Conflicts to remove disable and init
A little scary that the webauthn module didn't throw errors, so shows the need for some more tests for that module install
This covers the initial flow that got broken when the module didn't support the expected interface
cpb8010
force-pushed
the
module-interface
branch
from
0881ae8 to
3db6c9b
Compare
This no longer needs to be custom because there's no hooks yet
Have different options to remove trusted vs untrusted modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace IInitable with IModule that provides a way to specify the uninstall data. Retain the ability to directly disconnect a module without removing it.
Additional context
The disable function on the session key no longer work (and were never possible on passkeys), so this cleans up the initial intention to remove from the account by adding better interfaces for trusted modules.