[http_server] Make default hanlder for the base path in the "add_subapi" #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matt-42 both failed checks should be caused by some infra issue instead of the code change. |
...as the title says but in fact the code change is done by @samkpo in PR matt-42#127. I am just adding test coverage, making change in the right file with all files generated. This PR also adds one missing header file to to sql_database.hh to fix build breaks.
cong1920
force-pushed
the
subapi_endpoint_separation
branch
from
9ba895b to
65cbd76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...as the title says but in fact the code change is done by @samkpo in PR #127. I am just adding test coverage, making change in the right file with all files generated.