flag for initialReroute #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…issues with data model
… facilities from file. I cannot say if they are not set up correctly or if that execution path is not fully debugged, but it is something that we rarely use at VSP. The output now is as follows. Can't say if we should stick with the parking activity, or just use car interaction. 2023-04-25T04:45:12,079 WARN LeipzigRouterPlanAlgorithm:62 returning LeipzigPlanRouter 2023-04-25T04:45:12,080 WARN LeipzigRouterPlanAlgorithm:69 === old plan: === 2023-04-25T04:45:12,083 WARN LeipzigRouterPlanAlgorithm:71 act [type=leisure][coord=null][linkId=80][startTime=undefined][endTime=01:00:00][duration=undefined][facilityId=f_auto_80] 2023-04-25T04:45:12,095 WARN LeipzigRouterPlanAlgorithm:71 leg [mode=walk][depTime=01:00:00][travTime=00:00:00][arrTime=01:00:00][route= startLinkId=80 endLinkId=80 travTime=0.0 dist=0.0] 2023-04-25T04:45:12,095 WARN LeipzigRouterPlanAlgorithm:71 act [type=car interaction][coord=[x=7000.0 | y=7000.0]][linkId=80][startTime=undefined][endTime=undefined][duration=00:00:00][facilityId=null] 2023-04-25T04:45:12,096 WARN LeipzigRouterPlanAlgorithm:71 leg [mode=car][depTime=01:00:00][travTime=00:13:19][arrTime=01:13:19][route= startLinkId=80 endLinkId=81 travTime=799.0 dist=7000.0 linkIds=[170, 44, 134, 133, 36, 178] travelCost=2.6666600000000003] 2023-04-25T04:45:12,096 WARN LeipzigRouterPlanAlgorithm:71 act [type=car interaction][coord=[x=8000.0 | y=7000.0]][linkId=81][startTime=undefined][endTime=undefined][duration=00:00:00][facilityId=null] 2023-04-25T04:45:12,096 WARN LeipzigRouterPlanAlgorithm:71 leg [mode=walk][depTime=01:13:19][travTime=00:00:00][arrTime=01:13:19][route= startLinkId=81 endLinkId=81 travTime=0.0 dist=0.0] 2023-04-25T04:45:12,096 WARN LeipzigRouterPlanAlgorithm:71 act [type=leisure][coord=null][linkId=81][startTime=undefined][endTime=undefined][duration=undefined][facilityId=f_auto_81] 2023-04-25T04:45:12,096 WARN LeipzigRouterPlanAlgorithm:73 ====== 2023-04-25T04:45:12,096 WARN LeipzigRouterPlanAlgorithm:82 fromFacility=[org.matsim.facilities.ActivityFacilityImpl@d84b3a2 ID=f_auto_80| linkID=80| nof_activities=1] 2023-04-25T04:45:12,097 INFO NetworkImpl:419 building QuadTree for nodes: xrange(-1.0,9001.0); yrange(-1.0,9001.0) 2023-04-25T04:45:12,099 INFO NetworkImpl:428 Building QuadTree took 0.001 seconds. 2023-04-25T04:45:12,101 WARN LeipzigRouterPlanAlgorithm:141 === new plan: === 2023-04-25T04:45:12,101 WARN LeipzigRouterPlanAlgorithm:143 act [type=leisure][coord=null][linkId=80][startTime=undefined][endTime=01:00:00][duration=undefined][facilityId=f_auto_80] 2023-04-25T04:45:12,102 WARN LeipzigRouterPlanAlgorithm:143 leg [mode=walk][depTime=01:00:00][travTime=00:00:00][arrTime=01:00:00][route= startLinkId=80 endLinkId=169 travTime=0.0 dist=0.0] 2023-04-25T04:45:12,102 WARN LeipzigRouterPlanAlgorithm:143 act [type=parking interaction][coord=null][linkId=169][startTime=undefined][endTime=undefined][duration=00:00:00][facilityId=null] 2023-04-25T04:45:12,102 WARN LeipzigRouterPlanAlgorithm:143 leg [mode=car][depTime=01:00:00][travTime=00:13:21][arrTime=01:13:21][route= startLinkId=169 endLinkId=81 travTime=801.0 dist=7000.0 linkIds=[79, 124, 34, 35, 36, 178] travelCost=2.6711066666666667] 2023-04-25T04:45:12,102 WARN LeipzigRouterPlanAlgorithm:143 act [type=car interaction][coord=[x=8000.0 | y=7000.0]][linkId=81][startTime=undefined][endTime=undefined][duration=00:00:00][facilityId=null] 2023-04-25T04:45:12,102 WARN LeipzigRouterPlanAlgorithm:143 leg [mode=walk][depTime=01:13:21][travTime=00:00:00][arrTime=01:13:21][route= startLinkId=81 endLinkId=81 travTime=0.0 dist=0.0] 2023-04-25T04:45:12,102 WARN LeipzigRouterPlanAlgorithm:143 act [type=leisure][coord=null][linkId=81][startTime=undefined][endTime=undefined][duration=undefined][facilityId=f_auto_81] 2023-04-25T04:45:12,102 WARN LeipzigRouterPlanAlgorithm:145 ======
# Conflicts: # src/test/java/org/matsim/run/prepare/NetworkOptionsTest.java
…ific name pattern" This reverts commit 4e07fd5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LeipzigRouterPlanAlgorithmreroutes every trip. Currently, we always do that. For policy cases, this is unwanted and potentially a bit problematic, because we do not start from the equilibrium state. Therefore I propose a flag to trigger rerouting prior to the simulation. To account for the car-free area policy cases, I propose in #38 to delete routes from trips that touch a car-free area. Those trips should then be rerouted byPersonPrepareForSim, no need to run our customLeipzigRouterPlanAlgorithm(which then reroutes everything).