This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Update tests not to mock out an ancient server #12081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of our tests, which mock a `/versions` response, currently mock the response of a 2-year-old server. This will soon be incompatible with the JS-SDK. Update the tests in preparation.
richvdh
added
the
T-Task
This was referenced Dec 21, 2023
|
I think this is failing tests because element-hq/element-web#26796 has not yet landed. Hopefully they will pass once it does. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our tests, which mock a
/versionsresponse, currently mock the response of a 2-year-old server. This will soon be incompatible with the JS-SDK. Update the tests in preparation.(I'm sure there are hundreds of ways this could be better and less duplicative; however I can't really spare the time for a larger refactor and I consider this an objective improvement).
Prerequisite for matrix-org/matrix-js-sdk#3970.
This change is marked as an internal change (Task), so will not be included in the changelog.