-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: Update Matplotlib and pydata sphinx theme #92
Conversation
be804a9
to
5335822
Compare
OK, managed to get it building; however there are some differences in the result:
|
Since we‘re based on pydata-sphinx-theme, we should follow most of their design decisions. The more we customize, the more we have maintenance on future updates. For example, the underlining is a conscious accessibility decision. Additionally, the same changes apply to our main docs, and we want consistency between them. We should simply accept most of the changes. The only things to watch out for are css changes on their side that affect custom elements on our side in a negative way ( parts of the primary highlight color). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi folks - passing by 😄
One thing to consider is that the landing page will look different from the rest of the docs with the customizations (in fact, it already does. For example, link highlights on hover are in orange for the landing page but purple for the rest of the pages).
For the other things, a couple of changes to the landing.css
file should fix most of it. I am happy to push a commit here if that's easier. I also recommend adding
html_theme_options = {
"back_to_top_button": False,
}
to conf.py to turn off the back to top button in the landing pages. Cheers!
d71ff19
to
c7f6d79
Compare
So I think I actually misunderstood some of the style; I thought we had set blue/orange for links to follow our default colour cycle, but it turns out that was just the default from
These were because colours were set on
Same as above; fixed here.
Similarly, this is because the theme/Sphinx started setting colour on
Done. |
I didn't test, so we'll see how the build goes.