Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Intl extension to anglicisation #22870

Merged
merged 4 commits into from
Jan 17, 2025
Merged

Conversation

vibbow
Copy link
Contributor

@vibbow vibbow commented Dec 16, 2024

Description:

This fix the issue iconv will raise a Notice on some character.

For example:

$src = 'Debubawi K’eyyĭḥ Baḥri';
echo iconv('UTF-8', 'ASCII//TRANSLIT', $src);

// Expect output:
Debubawi K'eyyih Bahri

// Actually behaviour: 
Notice: iconv(): Detected an illegal character in input string

This should fix bug #22321

Review

Copy link
Contributor

github-actions bot commented Jan 1, 2025

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jan 1, 2025
@michalkleiner michalkleiner removed the Stale The label used by the Close Stale Issues action label Jan 1, 2025
Copy link
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jan 16, 2025
@vibbow vibbow requested a review from michalkleiner January 16, 2025 03:40
Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me, what do you think @sgiehl?

@michalkleiner michalkleiner added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Needs Review PRs that need a code review c: i18n For issues around internationalisation and localisation. and removed Stale The label used by the Close Stale Issues action labels Jan 16, 2025
@michalkleiner michalkleiner requested a review from sgiehl January 16, 2025 09:45
@michalkleiner michalkleiner added this to the 5.3.0 milestone Jan 16, 2025
@sgiehl sgiehl merged commit b64e4ca into matomo-org:5.x-dev Jan 17, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: i18n For issues around internationalisation and localisation. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants