This repository has been archived by the owner on Mar 11, 2024. It is now read-only.
Code refactoring #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Load/Save rates from/to cache file
|
Wow, overall looks pretty awesome. I have a few (mostly stylistic) concerns, but I definitely want to get this merged. I'll get back to you with some more detailed notes as soon as I have a bit more time on my hands. Feel free to ping me if you don't hear back from me by the end of the week. Thanks a lot for the PR! |
|
@matiaskorhonen ping ;) |
| --no-style | ||
| --style-measure 99 | ||
| --abc-max 18 | ||
| --style-exclude spec/**/* |
There was a problem hiding this comment.
What's a .cane file and why should I merge it in with this PR?
There was a problem hiding this comment.
|
Thanks, I added some comments and questions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load/Save rates from/to cache file