MATLAB Kernel does not communicate with MATLAB through Jupyter Server.

fixes #77 fixes #55 fixes #48 fixes #41 fixes #30 fixes #27 fixes #24
mathworks · Jan 7, 2025 · 6d0b5a7 · 6d0b5a7
1 parent 70d6dc1
commit 6d0b5a7
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/src/jupyter_matlab_kernel/base_kernel.py b/src/jupyter_matlab_kernel/base_kernel.py
@@ -1,4 +1,4 @@
-# Copyright 2023-2024 The MathWorks, Inc.
+# Copyright 2023-2025 The MathWorks, Inc.
 
 """
 This module serves as the base class for various MATLAB Kernels.
@@ -72,10 +72,10 @@ def _fetch_jupyter_base_url(parent_pid: str, logger: Logger) -> Optional[str]:
         logger.debug(
             "Jupyter server associated with this MATLAB Kernel not found, might a non-jupyter based MATLAB Kernel"
         )
-        return None
+    return None
 
 
-def _get_parent_pid() -> str:
+def _get_parent_pid() -> int:
     """
     Retrieves the parent process ID (PID) of the Kernel process.
 

diff --git a/src/jupyter_matlab_kernel/kernel_factory.py b/src/jupyter_matlab_kernel/kernel_factory.py
@@ -1,4 +1,4 @@
-# Copyright 2024 The MathWorks, Inc.
+# Copyright 2024-2025 The MathWorks, Inc.
 
 import os
 from typing import Union
@@ -25,7 +25,7 @@ def _is_fallback_kernel_enabled():
         """
 
         # Get the env var toggle
-        use_fallback_kernel = os.getenv("MWI_USE_FALLBACK_KERNEL", "TRUE")
+        use_fallback_kernel = os.getenv("MWI_USE_FALLBACK_KERNEL", "FALSE")
         return use_fallback_kernel.lower().strip() == "true"
 
     @staticmethod

diff --git a/src/jupyter_matlab_proxy/__init__.py b/src/jupyter_matlab_proxy/__init__.py
@@ -1,4 +1,4 @@
-# Copyright 2020-2024 The MathWorks, Inc.
+# Copyright 2020-2025 The MathWorks, Inc.
 
 import os
 import secrets
@@ -15,7 +15,7 @@
 _MPM_AUTH_TOKEN: str = secrets.token_hex(32)
 _JUPYTER_SERVER_PID: str = str(os.getpid())
 _USE_FALLBACK_KERNEL: bool = (
-    os.getenv("MWI_USE_FALLBACK_KERNEL", "TRUE").lower().strip() == "true"
+    os.getenv("MWI_USE_FALLBACK_KERNEL", "FALSE").lower().strip() == "true"
 )
 
 

diff --git a/tests/unit/jupyter_matlab_kernel/test_kernel_factory.py b/tests/unit/jupyter_matlab_kernel/test_kernel_factory.py
@@ -1,4 +1,4 @@
-# Copyright 2024 The MathWorks, Inc.
+# Copyright 2024-2025 The MathWorks, Inc.
 
 import pytest
 
@@ -47,4 +47,4 @@ def test_correct_kernel_type_is_returned_when_env_var_unset(monkeypatch):
     """
     monkeypatch.delenv("MWI_USE_FALLBACK_KERNEL", raising=False)
     kernel_class = KernelFactory.get_kernel_class()
-    assert kernel_class is MATLABKernelUsingJSP
+    assert kernel_class is MATLABKernelUsingMPM