Correct eslint error

mateusz-garlacz · Mar 6, 2020 · 7fee1cd · 7fee1cd
1 parent f6c1bb3
commit 7fee1cd
Show file tree

Hide file tree

Showing 21 changed files with 24 additions and 206 deletions.
diff --git a/advanced/kernel-messaging/.eslintrc.js b/advanced/kernel-messaging/.eslintrc.js
@@ -23,18 +23,6 @@ module.exports = {
         accessibility: 'explicit'
       }
     ],
-    '@typescript-eslint/indent': [
-      'error',
-      2,
-      {
-        FunctionDeclaration: {
-          parameters: 'first'
-        },
-        FunctionExpression: {
-          parameters: 'first'
-        }
-      }
-    ],
     '@typescript-eslint/interface-name-prefix': 'error',
     '@typescript-eslint/member-delimiter-style': [
       'error',
@@ -54,6 +42,7 @@ module.exports = {
     '@typescript-eslint/no-explicit-any': 'off',
     '@typescript-eslint/no-floating-promises': 'error',
     '@typescript-eslint/no-inferrable-types': 'off',
+    '@typescript-eslint/no-namespace': 'off',
     '@typescript-eslint/no-require-imports': 'off',
     '@typescript-eslint/no-use-before-define': 'off',
     '@typescript-eslint/no-var-requires': 'error',
@@ -128,7 +117,6 @@ module.exports = {
     'no-empty': 'error',
     'no-eval': 'error',
     'no-fallthrough': 'error',
-    'no-invalid-this': 'error',
     'no-multiple-empty-lines': 'off',
     'no-new-wrappers': 'error',
     'no-null/no-null': 'off',
@@ -140,7 +128,6 @@ module.exports = {
       }
     ],
     'no-trailing-spaces': 'error',
-    'no-underscore-dangle': 'error',
     'no-unused-labels': 'error',
     'no-var': 'error',
     'one-var': ['error', 'never'],

diff --git a/advanced/kernel-messaging/src/model.ts b/advanced/kernel-messaging/src/model.ts
@@ -49,7 +49,7 @@ export class KernelModel {
   }
 
   private _onIOPub = (msg: KernelMessage.IIOPubMessage) => {
-    let msgType = msg.header.msg_type;
+    const msgType = msg.header.msg_type;
     switch (msgType) {
       case 'execute_result':
       case 'display_data':

diff --git a/advanced/kernel-output/.eslintrc.js b/advanced/kernel-output/.eslintrc.js
@@ -23,18 +23,6 @@ module.exports = {
         accessibility: 'explicit'
       }
     ],
-    '@typescript-eslint/indent': [
-      'error',
-      2,
-      {
-        FunctionDeclaration: {
-          parameters: 'first'
-        },
-        FunctionExpression: {
-          parameters: 'first'
-        }
-      }
-    ],
     '@typescript-eslint/interface-name-prefix': 'error',
     '@typescript-eslint/member-delimiter-style': [
       'error',
@@ -54,6 +42,7 @@ module.exports = {
     '@typescript-eslint/no-explicit-any': 'off',
     '@typescript-eslint/no-floating-promises': 'error',
     '@typescript-eslint/no-inferrable-types': 'off',
+    '@typescript-eslint/no-namespace': 'off',
     '@typescript-eslint/no-require-imports': 'off',
     '@typescript-eslint/no-use-before-define': 'off',
     '@typescript-eslint/no-var-requires': 'error',
@@ -128,7 +117,6 @@ module.exports = {
     'no-empty': 'error',
     'no-eval': 'error',
     'no-fallthrough': 'error',
-    'no-invalid-this': 'error',
     'no-multiple-empty-lines': 'off',
     'no-new-wrappers': 'error',
     'no-null/no-null': 'off',
@@ -140,7 +128,6 @@ module.exports = {
       }
     ],
     'no-trailing-spaces': 'error',
-    'no-underscore-dangle': 'error',
     'no-unused-labels': 'error',
     'no-var': 'error',
     'one-var': ['error', 'never'],

diff --git a/advanced/server-extension/.eslintrc.js b/advanced/server-extension/.eslintrc.js
@@ -23,18 +23,6 @@ module.exports = {
         accessibility: 'explicit'
       }
     ],
-    '@typescript-eslint/indent': [
-      'error',
-      2,
-      {
-        FunctionDeclaration: {
-          parameters: 'first'
-        },
-        FunctionExpression: {
-          parameters: 'first'
-        }
-      }
-    ],
     '@typescript-eslint/interface-name-prefix': 'error',
     '@typescript-eslint/member-delimiter-style': [
       'error',
@@ -54,6 +42,7 @@ module.exports = {
     '@typescript-eslint/no-explicit-any': 'off',
     '@typescript-eslint/no-floating-promises': 'error',
     '@typescript-eslint/no-inferrable-types': 'off',
+    '@typescript-eslint/no-namespace': 'off',
     '@typescript-eslint/no-require-imports': 'off',
     '@typescript-eslint/no-use-before-define': 'off',
     '@typescript-eslint/no-var-requires': 'error',
@@ -128,7 +117,6 @@ module.exports = {
     'no-empty': 'error',
     'no-eval': 'error',
     'no-fallthrough': 'error',
-    'no-invalid-this': 'error',
     'no-multiple-empty-lines': 'off',
     'no-new-wrappers': 'error',
     'no-null/no-null': 'off',
@@ -140,7 +128,6 @@ module.exports = {
       }
     ],
     'no-trailing-spaces': 'error',
-    'no-underscore-dangle': 'error',
     'no-unused-labels': 'error',
     'no-var': 'error',
     'one-var': ['error', 'never'],

diff --git a/basics/datagrid/.eslintrc.js b/basics/datagrid/.eslintrc.js
@@ -23,18 +23,6 @@ module.exports = {
         accessibility: 'explicit'
       }
     ],
-    '@typescript-eslint/indent': [
-      'error',
-      2,
-      {
-        FunctionDeclaration: {
-          parameters: 'first'
-        },
-        FunctionExpression: {
-          parameters: 'first'
-        }
-      }
-    ],
     '@typescript-eslint/interface-name-prefix': 'error',
     '@typescript-eslint/member-delimiter-style': [
       'error',
@@ -54,6 +42,7 @@ module.exports = {
     '@typescript-eslint/no-explicit-any': 'off',
     '@typescript-eslint/no-floating-promises': 'error',
     '@typescript-eslint/no-inferrable-types': 'off',
+    '@typescript-eslint/no-namespace': 'off',
     '@typescript-eslint/no-require-imports': 'off',
     '@typescript-eslint/no-use-before-define': 'off',
     '@typescript-eslint/no-var-requires': 'error',
@@ -128,7 +117,6 @@ module.exports = {
     'no-empty': 'error',
     'no-eval': 'error',
     'no-fallthrough': 'error',
-    'no-invalid-this': 'error',
     'no-multiple-empty-lines': 'off',
     'no-new-wrappers': 'error',
     'no-null/no-null': 'off',
@@ -140,7 +128,6 @@ module.exports = {
       }
     ],
     'no-trailing-spaces': 'error',
-    'no-underscore-dangle': 'error',
     'no-unused-labels': 'error',
     'no-var': 'error',
     'one-var': ['error', 'never'],

diff --git a/basics/hello-world/.eslintrc.js b/basics/hello-world/.eslintrc.js
@@ -23,18 +23,6 @@ module.exports = {
         accessibility: 'explicit'
       }
     ],
-    '@typescript-eslint/indent': [
-      'error',
-      2,
-      {
-        FunctionDeclaration: {
-          parameters: 'first'
-        },
-        FunctionExpression: {
-          parameters: 'first'
-        }
-      }
-    ],
     '@typescript-eslint/interface-name-prefix': 'error',
     '@typescript-eslint/member-delimiter-style': [
       'error',
@@ -54,6 +42,7 @@ module.exports = {
     '@typescript-eslint/no-explicit-any': 'off',
     '@typescript-eslint/no-floating-promises': 'error',
     '@typescript-eslint/no-inferrable-types': 'off',
+    '@typescript-eslint/no-namespace': 'off',
     '@typescript-eslint/no-require-imports': 'off',
     '@typescript-eslint/no-use-before-define': 'off',
     '@typescript-eslint/no-var-requires': 'error',
@@ -128,7 +117,6 @@ module.exports = {
     'no-empty': 'error',
     'no-eval': 'error',
     'no-fallthrough': 'error',
-    'no-invalid-this': 'error',
     'no-multiple-empty-lines': 'off',
     'no-new-wrappers': 'error',
     'no-null/no-null': 'off',
@@ -140,7 +128,6 @@ module.exports = {
       }
     ],
     'no-trailing-spaces': 'error',
-    'no-underscore-dangle': 'error',
     'no-unused-labels': 'error',
     'no-var': 'error',
     'one-var': ['error', 'never'],

diff --git a/basics/signals/.eslintrc.js b/basics/signals/.eslintrc.js
@@ -23,18 +23,6 @@ module.exports = {
         accessibility: 'explicit'
       }
     ],
-    '@typescript-eslint/indent': [
-      'error',
-      2,
-      {
-        FunctionDeclaration: {
-          parameters: 'first'
-        },
-        FunctionExpression: {
-          parameters: 'first'
-        }
-      }
-    ],
     '@typescript-eslint/interface-name-prefix': 'error',
     '@typescript-eslint/member-delimiter-style': [
       'error',
@@ -54,6 +42,7 @@ module.exports = {
     '@typescript-eslint/no-explicit-any': 'off',
     '@typescript-eslint/no-floating-promises': 'error',
     '@typescript-eslint/no-inferrable-types': 'off',
+    '@typescript-eslint/no-namespace': 'off',
     '@typescript-eslint/no-require-imports': 'off',
     '@typescript-eslint/no-use-before-define': 'off',
     '@typescript-eslint/no-var-requires': 'error',
@@ -128,7 +117,6 @@ module.exports = {
     'no-empty': 'error',
     'no-eval': 'error',
     'no-fallthrough': 'error',
-    'no-invalid-this': 'error',
     'no-multiple-empty-lines': 'off',
     'no-new-wrappers': 'error',
     'no-null/no-null': 'off',
@@ -140,7 +128,6 @@ module.exports = {
       }
     ],
     'no-trailing-spaces': 'error',
-    'no-underscore-dangle': 'error',
     'no-unused-labels': 'error',
     'no-var': 'error',
     'one-var': ['error', 'never'],

diff --git a/command-palette/.eslintrc.js b/command-palette/.eslintrc.js
@@ -23,18 +23,6 @@ module.exports = {
         accessibility: 'explicit'
       }
     ],
-    '@typescript-eslint/indent': [
-      'error',
-      2,
-      {
-        FunctionDeclaration: {
-          parameters: 'first'
-        },
-        FunctionExpression: {
-          parameters: 'first'
-        }
-      }
-    ],
     '@typescript-eslint/interface-name-prefix': 'error',
     '@typescript-eslint/member-delimiter-style': [
       'error',
@@ -54,6 +42,7 @@ module.exports = {
     '@typescript-eslint/no-explicit-any': 'off',
     '@typescript-eslint/no-floating-promises': 'error',
     '@typescript-eslint/no-inferrable-types': 'off',
+    '@typescript-eslint/no-namespace': 'off',
     '@typescript-eslint/no-require-imports': 'off',
     '@typescript-eslint/no-use-before-define': 'off',
     '@typescript-eslint/no-var-requires': 'error',
@@ -128,7 +117,6 @@ module.exports = {
     'no-empty': 'error',
     'no-eval': 'error',
     'no-fallthrough': 'error',
-    'no-invalid-this': 'error',
     'no-multiple-empty-lines': 'off',
     'no-new-wrappers': 'error',
     'no-null/no-null': 'off',
@@ -140,7 +128,6 @@ module.exports = {
       }
     ],
     'no-trailing-spaces': 'error',
-    'no-underscore-dangle': 'error',
     'no-unused-labels': 'error',
     'no-var': 'error',
     'one-var': ['error', 'never'],

diff --git a/command-palette/src/index.ts b/command-palette/src/index.ts
@@ -15,7 +15,7 @@ const extension: JupyterFrontEndPlugin<void> = {
   activate: (app: JupyterFrontEnd, palette: ICommandPalette) => {
     const { commands } = app;
 
-    let command = 'jlab-examples:command-palette';
+    const command = 'jlab-examples:command-palette';
 
     // Add a command
     commands.addCommand(command, {
@@ -32,7 +32,7 @@ const extension: JupyterFrontEndPlugin<void> = {
     });
 
     // Add the command to the command palette
-    let category = 'Extension Examples';
+    const category = 'Extension Examples';
     palette.addItem({ command, category, args: { origin: 'from palette' } });
   }
 };

diff --git a/commands/.eslintrc.js b/commands/.eslintrc.js
@@ -23,18 +23,6 @@ module.exports = {
         accessibility: 'explicit'
       }
     ],
-    '@typescript-eslint/indent': [
-      'error',
-      2,
-      {
-        FunctionDeclaration: {
-          parameters: 'first'
-        },
-        FunctionExpression: {
-          parameters: 'first'
-        }
-      }
-    ],
     '@typescript-eslint/interface-name-prefix': 'error',
     '@typescript-eslint/member-delimiter-style': [
       'error',
@@ -54,6 +42,7 @@ module.exports = {
     '@typescript-eslint/no-explicit-any': 'off',
     '@typescript-eslint/no-floating-promises': 'error',
     '@typescript-eslint/no-inferrable-types': 'off',
+    '@typescript-eslint/no-namespace': 'off',
     '@typescript-eslint/no-require-imports': 'off',
     '@typescript-eslint/no-use-before-define': 'off',
     '@typescript-eslint/no-var-requires': 'error',
@@ -128,7 +117,6 @@ module.exports = {
     'no-empty': 'error',
     'no-eval': 'error',
     'no-fallthrough': 'error',
-    'no-invalid-this': 'error',
     'no-multiple-empty-lines': 'off',
     'no-new-wrappers': 'error',
     'no-null/no-null': 'off',
@@ -140,7 +128,6 @@ module.exports = {
       }
     ],
     'no-trailing-spaces': 'error',
-    'no-underscore-dangle': 'error',
     'no-unused-labels': 'error',
     'no-var': 'error',
     'one-var': ['error', 'never'],

diff --git a/commands/src/index.ts b/commands/src/index.ts
@@ -12,7 +12,7 @@ const extension: JupyterFrontEndPlugin<void> = {
   activate: (app: JupyterFrontEnd) => {
     const { commands } = app;
 
-    let command = 'jlab-examples:command';
+    const command = 'jlab-examples:command';
 
     // Add a command
     commands.addCommand(command, {