🌱 Enable govet settings and fix issue found (kubernetes-sigs#4465)

Fix linter error `nilness: impossible condition: nil != nil (govet)` ``` golangci-lint run pkg/plugins/golang/v4/scaffolds/edit.go:60:9: nilness: impossible condition: nil != nil (govet) if err != nil && s.multigroup != s.config.IsMultiGroup() { ^ make: *** [lint] Error 1 ``` Signed-off-by: Mateus Oliveira <[email protected]>
mateusoliveira43 · Jan 2, 2025 · 18df538 · 18df538
1 parent f051464
commit 18df538
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -17,6 +17,11 @@ issues:
         - gosec
 
 linters-settings:
+  govet:
+    enable-all: true
+    disable:
+      - fieldalignment
+      - shadow
   revive:
     rules:
       # The following rules are recommended https://github.com/mgechev/revive#recommended-configuration

diff --git a/pkg/plugins/golang/v4/scaffolds/edit.go b/pkg/plugins/golang/v4/scaffolds/edit.go
@@ -56,11 +56,6 @@ func (s *editScaffolder) Scaffold() error {
 	}
 	str := string(bs)
 
-	// Ignore the error encountered, if the file is already in desired format.
-	if err != nil && s.multigroup != s.config.IsMultiGroup() {
-		return err
-	}
-
 	if s.multigroup {
 		_ = s.config.SetMultiGroup()
 	} else {