-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorials for QHA and Grüneisen workflows #1122
Conversation
…ter_documentation
Note here: i had to exclude one file from ruff as ruff-format would do the exact opposite. |
always good to see more docs and tutorials! 👍 curious though, is it really necessary to commit ~400 test files alongside these tutorials? seems like this could bloat the repo over time |
@janosh, I agree with you that this might be a large number, but otherwise, people cannot test the workflows with realistic data. |
I think i had a look at the data size: it was not more than 4 MB |
@janosh To add further, i think this is currently one of our most complex workflows. We can, unfortunately, not run it with most of the forcefields as the accuracy is not good enough yet. I might be able to reduce the number of points along the ev curve a bit to get still a good fit but that would mean running yet another workflow just for test data. Not sure it is worth the effort in this one case. Btw, we now have: https://materialsproject.github.io/atomate2/tutorials/tutorials.html |
Summary