[adaptive_navigation] Add Material 3 support. #509
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
zbLiuLiu
changed the title
| @@ -1,3 +1,7 @@ | |||
| ## Unreleased | |||
| ### Added | |||
| - Add Material 3 support. | |||
There was a problem hiding this comment.
| - Add Material 3 support. | |
| - Added Material 3 support |
| icon: Icon(destination.icon), | ||
| label: Text(destination.title), | ||
| ), | ||
| // const Spacer(), |
There was a problem hiding this comment.
please remove or uncomment
| double elevation = navigation.elevation ?? | ||
| Theme.of(context).navigationDrawerTheme.elevation ?? | ||
| 1.0; | ||
| return Material( |
There was a problem hiding this comment.
why the need for this Material?
| @@ -39,12 +40,12 @@ class AdaptiveScaffoldDestination { | |||
| }); | |||
| } | |||
|
|
|||
| /// A widget that adapts to the current display size, displaying a [Drawer], | |||
| /// [NavigationRail], or [BottomNavigationBar]. Navigation destinations are | |||
| /// A widget that adapts to the current display size, displaying a [Drawer]/[NavigationDrawer], | |||
There was a problem hiding this comment.
please adopt https://dart.dev/effective-dart/documentation#do-separate-the-first-sentence-of-a-doc-comment-into-its-own-paragraph
also, can you clarify that [NavigationDrawer] is if the ambient [ThemeData.useMaterial3] is true, otherwise [Drawer] is used.
|
The adaptive packages have been discontinued, therefore I must close this PR. Thanks! |
Description
Add Material 3 support. Automatically use NavigationDrawer and NavigationBar while
ThemeData.useMaterial3is true.Tests
Add
themeprop inMaterialAppand setuseMaterial3to true.Checklist
CHANGELOG.md