Conversation
|
The CL tools can't recognize generated files, so here's the svg outputs: file
folder
folder-open
folder-root
folder-root-open
|
There was a problem hiding this comment.
I'm not super happy with the fact that the file icon is not aligned in the middle. Typically - if possible - we try to have one pixel above and one below and try to center the rest of the icon in the remaining 14 pixels. Additionally, the edge on the top right looks a little too thick. Do you think we can improve this a little bit? I'm also open for a new file design, but it should look good and not just fulfill some pixel perfext guidelines. Fulfilling both requirements would of course be perfect.
There was a problem hiding this comment.
Oh? I was under the assumption that being pixel-perfect @ 16×16 was a new soft-requirement. That'll make this a loooot easier if there's some wiggle-room
There was a problem hiding this comment.
I could make out some differences between the normal folder icon and some specific folder icons (in this case the folder-dist icon). Then I put both of them together and found out that there's a different design. I'd highly appreciate if we could use the same folder shape for the default and the specific folder icons:
There was a problem hiding this comment.
I agree with them being synced, but I'm not certain if that uniformity is actually enforced atm. It'd be nice if there was some way to explicitly sync these icons, but that might be outside the scope of this PR. I'll still look into it later today
Description
Converts all generated icons to a 16×16 format with pixel-perfect points, matching the updated contribution guidelines.
Contribution Guidelines