-
-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add lintstaged icon #2773
Conversation
PreviewThank you for creating a pull request. This preview shows you how your icons will look on the different themes: Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link. You can find more information on how to contribute in the contribution guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really don't like the poop on the icon, it's disgusting
You can replace it with something else, such as a 🦠 |
What do you think using only "🚫" |
That's also possible, but it would simply mean a ban, and if there's a virus inside, it would mean preventing something bad |
I also think you need to change the line thickness from 1 pixel to 1.5 for better visibility. |
And delete the light version of the icon |
I also don't like it... I'm not sure if it will work as file icon of this extension. |
Hi @okineadev, what if we use a complete different icon? Is that Ok? I was thinking using a "stop sign hand" ✋. |
bf847b7
to
be76a6a
Compare
I've created a follow-up PR #2794 :) |
Description
Add lintstaged support
Icon is based on lintstaged avatar: https://github.com/lint-staged
Recreate #2246
Contribution Guidelines