Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add lintstaged icon #2773

Closed

Conversation

tiagoporto
Copy link
Contributor

@tiagoporto tiagoporto commented Jan 2, 2025

Description

Add lintstaged support

Icon is based on lintstaged avatar: https://github.com/lint-staged

.lintstagedrc
.lintstagedrc.json
.lintstagedrc.yaml
.lintstagedrc.yml
.lintstagedrc.mjs
lint-staged.config.mjs
.lintstagedrc.cjs
lint-staged.config.cjs
lint-staged.config.js
.lintstagedrc.js

Recreate #2246

Contribution Guidelines

@github-actions github-actions bot added the 🏞️ icons PR with new icons label Jan 2, 2025
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Preview

Thank you for creating a pull request. This preview shows you how your icons will look on the different themes:

Generated preview

Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

Copy link
Contributor

@okineadev okineadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't like the poop on the icon, it's disgusting

@okineadev
Copy link
Contributor

You can replace it with something else, such as a 🦠

@tiagoporto
Copy link
Contributor Author

You can replace it with something else, such as a 🦠

What do you think using only "🚫"

@okineadev
Copy link
Contributor

You can replace it with something else, such as a 🦠

What do you think using only "🚫"

That's also possible, but it would simply mean a ban, and if there's a virus inside, it would mean preventing something bad

@okineadev
Copy link
Contributor

I also think you need to change the line thickness from 1 pixel to 1.5 for better visibility.

@okineadev
Copy link
Contributor

And delete the light version of the icon

@PKief
Copy link
Member

PKief commented Jan 3, 2025

I really don't like the poop on the icon, it's disgusting

I also don't like it... I'm not sure if it will work as file icon of this extension.

@tiagoporto
Copy link
Contributor Author

tiagoporto commented Jan 3, 2025

Hi @okineadev, what if we use a complete different icon? Is that Ok?

I was thinking using a "stop sign hand" ✋.

@okineadev okineadev changed the title feat: add lintstaged feat: add lintstaged icon Jan 4, 2025
@PKief PKief force-pushed the main branch 3 times, most recently from bf847b7 to be76a6a Compare January 6, 2025 21:18
@PKief PKief closed this Jan 6, 2025
@PKief
Copy link
Member

PKief commented Jan 6, 2025

@tiagoporto Sorry for closing the PR, would you mind reopening it?

I've created a follow-up PR #2794 :)

@PKief PKief mentioned this pull request Jan 6, 2025
2 tasks
@tiagoporto tiagoporto deleted the add-lintstaged branch January 8, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏞️ icons PR with new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants