still a lot to do #849
Open
still a lot to do #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choeqq
suggested changes
Oct 2, 2023
src/App.tsx
Outdated
| import { TodoList } from './components/TodoList/TodoList'; | ||
| import { Todo } from './types/Todo'; | ||
|
|
||
| // const USER_ID = 11569; |
src/App.tsx
Outdated
Comment on lines
18
to
28
| const [todos, setTodos] = useState<Todo[] >([]); | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| const [isLoading, setIsLoading] = useState<number[] | []>([]); | ||
|
|
||
| const [statusFilter, setStatusFilter] = useState('all'); | ||
|
|
||
| const [tempTodo, setTempTodo] = useState<Todo | null>(null); | ||
|
|
||
| const [error, setError] = useState(''); | ||
|
|
||
| const [addTodoForm, setAddTodoForm] = useState(''); |
There was a problem hiding this comment.
Suggested change
| const [todos, setTodos] = useState<Todo[] >([]); | |
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | |
| const [isLoading, setIsLoading] = useState<number[] | []>([]); | |
| const [statusFilter, setStatusFilter] = useState('all'); | |
| const [tempTodo, setTempTodo] = useState<Todo | null>(null); | |
| const [error, setError] = useState(''); | |
| const [addTodoForm, setAddTodoForm] = useState(''); | |
| const [todos, setTodos] = useState<Todo[] >([]); | |
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | |
| const [isLoading, setIsLoading] = useState<number[] | []>([]); | |
| const [statusFilter, setStatusFilter] = useState('all'); | |
| const [tempTodo, setTempTodo] = useState<Todo | null>(null); | |
| const [error, setError] = useState(''); | |
| const [addTodoForm, setAddTodoForm] = useState(''); |
src/App.tsx
Outdated
Comment on lines
83
to
85
| // const focusInput = () => { | ||
| // inputRef.current.focus(); | ||
| // }; |
src/App.tsx
Outdated
| setError('Unable to delete a todo'); | ||
| } finally { | ||
| setTimeout(() => { | ||
| setIsLoading(todos.filter(todo => todo.id !== todoId) as number[] | []); |
There was a problem hiding this comment.
try to type it better, you shouldn't have to use as
src/App.tsx
Outdated
| } | ||
| }; | ||
|
|
||
| const updateStatusHandler = (todo: Todo, data: {}) => { |
There was a problem hiding this comment.
you're forcing data to be empty object in your typing, which is not ideal
src/components/ToDoContext.tsx
Outdated
| @@ -0,0 +1,49 @@ | |||
| import React, { useContext, useState } from 'react'; | |||
| // import { useTodos } from './useTodos'; | |||
src/components/ToDoContext.tsx
Outdated
| }; | ||
|
|
||
| export const TodosProvider = ({ children, userId }: TodosProviderProps) => { | ||
| // const { isLoading, ...rest } = useTodos(userId); |
src/components/TodoList/TodoList.tsx
Outdated
|
|
||
| }, | ||
| ) => { | ||
| // const [todosUpdated, setTodosUpdated] = useState(0); |
src/components/TodoRow/TodoRow.tsx
Outdated
| import classNames from 'classnames'; | ||
| import { useRef, useState } from 'react'; | ||
| import { patchTodo } from '../../api/todos'; | ||
| // import { deleteTodoHandler } from '../../App' |
src/components/TodoRow/TodoRow.tsx
Outdated
| }) => { | ||
| const [isEdited, setIsEdited] = useState(false); | ||
| const [editTitle, setEditTitle] = useState(''); | ||
| const [isCompletedLocale] = useState(todo.completed); |
I'm still working on it, I haven't passed 3 tests and I haven't managed to do everything you marked yet, but I've sorted it out a bit and it's all over now. and the link already works ;D |
choeqq
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://MateuszSlezak.github.io/react_todo-app-with-api/