Solução parcialmente adicionada #1581
Conversation
src/App.tsx
Outdated
| .finally(() => { | ||
| dispatch({ type: 'stopUpdate' }); | ||
| }); | ||
| }, []); |
| import { Todo } from '../types/Todo'; | ||
| import { client } from '../utils/fetchClient'; | ||
|
|
||
| export const USER_ID = 2165; |
There was a problem hiding this comment.
Check this user here, you are setting the UserID (should be unique to you, Camille, not for who is using the website) to 2165.
Later on, you are passing a different number
src/components/NewTodoField.tsx
Outdated
| type: 'addTempTodo', | ||
| payload: { userId: 962, id: 0, title: title.trim(), completed: false }, | ||
| }); | ||
| addTodo({ userId: 962, title: title.trim(), completed: false }) |
There was a problem hiding this comment.
Here you are sending to the API an Todo that belongs to the UserId 962, which is a different number.
If the numbers mismatch, you are probably trying to load your todos in the GET method, but saving them to another user, so they won't be found by you.
|
Fiz as alterações, @pedro-ruas mas ele ta reprovando em um teste dizendo "Should stay open on fail" |
There was a problem hiding this comment.
Before making the changes, run dpeloy again and verify if the error persists on the pipeline.
If the error persists, let's try the change that I shared to see if changing that fixes the issue. Do not forget to run deploy command.
If the issue persists please send to me a message inside mate platform for me try to find a solution.
I run the test locally and all were passing
| /> | ||
| </label> | ||
|
|
||
| {isEditing && selectedTodo === todo.id ? ( |
There was a problem hiding this comment.
try to remove the logic selectedTodo === todo.id and deploy again the PR. Let's see if doing that the test pass
| @@ -519,7 +519,7 @@ describe('', () => { | |||
| }); | |||
|
|
|||
| // this test may be flaky | |||
| it.skip('should replace loader with a created todo', () => { | |||
| it('should replace loader with a created todo', () => { | |||
| @@ -1515,7 +1515,7 @@ describe('', () => { | |||
| }); | |||
|
|
|||
| // It depend on your implementation | |||
| it.skip('should stay while waiting', () => { | |||
| it('should stay while waiting', () => { | |||
| @@ -1694,7 +1694,7 @@ describe('', () => { | |||
| }); | |||
|
|
|||
| // this test may be unstable | |||
| it.skip('should hide loader on fail', () => { | |||
| it('should hide loader on fail', () => { | |||
|
@joaorpereira De fato joão, apenas rodar o deploy fez com que tudo passasse. Muito Obrigada! |
DEMO LINK
Eu sei que não está passando todos, mas não estou entendendo o último erro e como fazer os testes pausados rodarem