solution #1559
solution #1559
Conversation
| const activeTodosCount = useMemo( | ||
| () => todos.filter(todo => !todo.completed).length, | ||
| [todos], | ||
| ); | ||
| const completedTodosCount = useMemo( | ||
| () => todos.filter(todo => todo.completed).length, | ||
| [todos], | ||
| ); | ||
| const areAllTodosCompleted = useMemo( | ||
| () => todos.every(todo => todo.completed), | ||
| [todos], | ||
| ); |
There was a problem hiding this comment.
these three functions will work without useMemo, but they are also very good there
| placeholder="What needs to be done?" | ||
| ref={inputRef} | ||
| value={inputValue} | ||
| onChange={event => setInputValue(event.target.value)} |
| className="todo__title-field" | ||
| placeholder="Empty todo will be deleted" | ||
| value={todoTitleValue} | ||
| onChange={event => setTodoTitleValue(event.target.value)} |
| tempTodo: Todo | null; | ||
| loadingTodoIds: number[]; | ||
| onRemoveTodo: (todoId: number) => Promise<void>; | ||
| onUpdateTodo: (todo: Todo) => Promise<void>; |
There was a problem hiding this comment.
you sould change all functions that start with "on"
exmaple:
onUpdateTodo: (todo: Todo) => Promise<void>;
to
handleUpdateTodo: (todo: Todo) => Promise<void>;
There was a problem hiding this comment.
you sould change all functions that start with "on"
exmaple:
onUpdateTodo: (todo: Todo) => Promise<void>;tohandleUpdateTodo: (todo: Todo) => Promise<void>;
No, when you pass handlers as props they should start from on
https://javascript.plainenglish.io/handy-naming-conventions-for-event-handler-functions-props-in-react-fc1cbb791364
src/App.tsx
Outdated
| if (filterStatus === FilterStatus.All) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
You don't need to filter at all when filterStatus === FilterStatus.All
| tempTodo: Todo | null; | ||
| loadingTodoIds: number[]; | ||
| onRemoveTodo: (todoId: number) => Promise<void>; | ||
| onUpdateTodo: (todo: Todo) => Promise<void>; |
There was a problem hiding this comment.
you sould change all functions that start with "on"
exmaple:
onUpdateTodo: (todo: Todo) => Promise<void>;tohandleUpdateTodo: (todo: Todo) => Promise<void>;
No, when you pass handlers as props they should start from on
https://javascript.plainenglish.io/handy-naming-conventions-for-event-handler-functions-props-in-react-fc1cbb791364
DEMO LINK