Create todo app #1557
Open
Create todo app #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VolodymyrKirichenko
suggested changes
Dec 23, 2024
| }, {} as Loading); | ||
| }; | ||
|
|
||
| const todoFilter = todos.filter(todo => { |
There was a problem hiding this comment.
move this function to separate component or use useMemo for it
src/App.tsx
Outdated
Comment on lines
43
to
45
| interface Loading { | ||
| [key: number]: number; | ||
| } |
There was a problem hiding this comment.
move it outside the function
src/App.tsx
Outdated
Comment on lines
67
to
177
| setTempTodo(null); | ||
| }); | ||
| }; | ||
|
|
||
| const deleteTodoItem = (todoId: number): void => { | ||
| deleteTodo(todoId) | ||
| .then(() => { | ||
| setTodos(currentTodos => | ||
| currentTodos.filter(todo => todo.id !== todoId), | ||
| ); | ||
| }) | ||
| .catch(() => { | ||
| setErrorType(ErrorType.UnableToDelete); | ||
| }) | ||
| .finally(() => { | ||
| setTempTodo(null); | ||
| }); | ||
| }; | ||
|
|
||
| const updateTodoItems = ( | ||
| updateTodoItem: Todo, | ||
| key: keyof Todo, | ||
| value: boolean | string, | ||
| ): Promise<boolean> => { | ||
| return updateTodo({ ...updateTodoItem, [key]: value }) | ||
| .then(todoUpdated => { | ||
| setTodos(currentTodos => | ||
| currentTodos.map(todo => | ||
| todo.id === updateTodoItem.id ? todoUpdated : todo, | ||
| ), | ||
| ); | ||
|
|
||
| return false; | ||
| }) | ||
| .catch(() => { | ||
| setErrorType(ErrorType.UnableToUpdate); | ||
|
|
||
| return true; | ||
| }); | ||
| }; | ||
|
|
||
| const loadedDeleteTodo = (): void => { | ||
| const completedTodos = todos.filter(todo => todo.completed); | ||
|
|
||
| setTodoLoading(loadingTodo(completedTodos)); | ||
|
|
||
| Promise.allSettled( | ||
| completedTodos.map(todo => deleteTodo(todo.id).then(() => todo)), | ||
| ) | ||
| .then(values => { | ||
| values.forEach(val => { | ||
| if (val.status === 'rejected') { | ||
| setErrorType(ErrorType.UnableToDelete); | ||
| } else { | ||
| setTodos(currentTodos => { | ||
| const todoId = val.value as Todo; | ||
|
|
||
| return currentTodos.filter(todo => todo.id !== todoId.id); | ||
| }); | ||
| } | ||
| }); | ||
| }) | ||
| .finally(() => setTodoLoading({})); | ||
| }; | ||
|
|
||
| const handleAllCompleted = (): void => { | ||
| const completedAllTodos = ( | ||
| targetTodos: Todo[], | ||
| completed: boolean, | ||
| ): Promise<void> => { | ||
| return Promise.all( | ||
| targetTodos.map(todo => updateTodo({ ...todo, completed })), | ||
| ) | ||
| .then(() => { | ||
| setTodos(currentTodos => | ||
| currentTodos.map(todo => | ||
| targetTodos.some(t => t.id === todo.id) | ||
| ? { ...todo, completed } | ||
| : todo, | ||
| ), | ||
| ); | ||
| }) | ||
| .catch(() => { | ||
| setErrorType(ErrorType.UnableToUpdate); | ||
| }) | ||
| .finally(() => { | ||
| setTodoLoading({}); | ||
| }); | ||
| }; | ||
|
|
||
| const activeTodos = todos.filter(todo => !todo.completed); | ||
|
|
||
| if (activeTodos.length) { | ||
| setTodoLoading(loadingTodo(activeTodos)); | ||
| completedAllTodos(activeTodos, true); | ||
| } else { | ||
| setTodoLoading(loadingTodo(todos)); | ||
| completedAllTodos(todos, false); | ||
| } | ||
| }; |
There was a problem hiding this comment.
- do we need
useCallbackfor these function? for which one? - use naming convention for all the functions. For all such cases
src/App.tsx
Outdated
| setErrorType={setErrorType} | ||
| onChangeTodoTask={setTempTodo} | ||
| tempTodo={tempTodo} | ||
| addNewTodo={addNewTodo} |
There was a problem hiding this comment.
Suggested change
| addNewTodo={addNewTodo} | |
| onAddNewTodo={handleAddNewTodo} |
src/commponents/Footer.tsx
Outdated
| import { Status } from '../types/Status'; | ||
| import { Todo } from '../types/Todo'; | ||
|
|
||
| interface LoadingTodo { |
There was a problem hiding this comment.
I've seen this type before. Extract it to a separate file and export it.
Import it wherever u need it
src/commponents/Footer.tsx
Outdated
| [todos], | ||
| ); | ||
|
|
||
| const onTodoCompleted = useMemo( |
There was a problem hiding this comment.
on?why?
i see that this variable contains boolean value and doesn't change anything
| () => todos.some(todo => todo.completed), | ||
| [todos], | ||
| ); | ||
| let onCompletedDelete = false; |
src/commponents/Footer.tsx
Outdated
Comment on lines
45
to
62
| </span> | ||
| <nav className="filter" data-cy="Filter"> | ||
| {filtersValue.map(filter => ( | ||
| <a | ||
| key={filter} | ||
| href={`#/${filter !== Status.All && filter.toLowerCase()}`} | ||
| className={cn('filter__link', { | ||
| selected: filter === filterType, | ||
| })} | ||
| data-cy={`FilterLink${filter}`} | ||
| onClick={() => onFiltered(filter)} | ||
| > | ||
| {filter} | ||
| </a> | ||
| ))} | ||
| </nav> | ||
| <button | ||
| type="button" |
There was a problem hiding this comment.
don't forget about indents(for all cases)
Suggested change
| </span> | |
| <nav className="filter" data-cy="Filter"> | |
| {filtersValue.map(filter => ( | |
| <a | |
| key={filter} | |
| href={`#/${filter !== Status.All && filter.toLowerCase()}`} | |
| className={cn('filter__link', { | |
| selected: filter === filterType, | |
| })} | |
| data-cy={`FilterLink${filter}`} | |
| onClick={() => onFiltered(filter)} | |
| > | |
| {filter} | |
| </a> | |
| ))} | |
| </nav> | |
| <button | |
| type="button" | |
| </span> | |
| <nav className="filter" data-cy="Filter"> | |
| {filtersValue.map(filter => ( | |
| <a | |
| key={filter} | |
| href={`#/${filter !== Status.All && filter.toLowerCase()}`} | |
| className={cn('filter__link', { | |
| selected: filter === filterType, | |
| })} | |
| data-cy={`FilterLink${filter}`} | |
| onClick={() => onFiltered(filter)} | |
| > | |
| {filter} | |
| </a> | |
| ))} | |
| </nav> | |
| <button | |
| type="button" |
src/commponents/Header.tsx
Outdated
|
|
||
| const todoUseRef = useRef<HTMLInputElement>(null); | ||
|
|
||
| const completedTodos = todos.every(todo => todo.completed); |
StasSokolov1
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
Все працює, але падає тест. Було б добре, щоб глянув ментор, в чому може бути причина. Дякую.