Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React phone catalog #569

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

React phone catalog #569

wants to merge 16 commits into from

Conversation

MaksymMohyla
Copy link

https://maksymmohyla.github.io/react_phone-catalog/ - Demo. May load properly only after first reload

volodymyr-soltys97
volodymyr-soltys97 suggested changes Jan 25, 2025
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your code

  1. The maximum quantity limit of 5 units needs to be removed here
image
  1. Fix styles for this item as on the design, pls check it
image
  1. Remove scroll when the menu is open
image
  1. Fix this UI bug
image
  1. You need to center these links
image

anastasiiavorobiova
anastasiiavorobiova suggested changes Jan 26, 2025
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

  • Screenshot 2025-01-26 at 15 37 42
  • Check styles here
  • Also, a user should be able to delete the product from the cart
  • Screenshot 2025-01-26 at 15 37 27

volodymyr-soltys97
volodymyr-soltys97 approved these changes Jan 26, 2025
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🔥

@MaksymMohyla
Copy link
Author

Great work! 🔥

Thank you, finally I made after 1 month of work and with lots of help from mentors!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volodymyr-soltys97 volodymyr-soltys97 volodymyr-soltys97 approved these changes

@anastasiiavorobiova anastasiiavorobiova Awaiting requested review from anastasiiavorobiova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaksymMohyla @volodymyr-soltys97 @anastasiiavorobiova