Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement phone catalog #566

Open
wants to merge 93 commits into
base: master
Choose a base branch
from
Open

Implement phone catalog #566

wants to merge 93 commits into from

Conversation

deezhizyu
Copy link

@deezhizyu deezhizyu commented Jan 19, 2025 •
edited
Loading

@deezhizyu
Update rules for end line
9c01b2a
@deezhizyu
Implement header design
6029c6d
@deezhizyu
Create HomePage component and implement banner
c754288
@deezhizyu
Fix linting errors
338eb7c
@deezhizyu
Fix header nav items height
db4ac70
@deezhizyu
Use semantic <header> tag in Header
40f6597
@deezhizyu
Fix font-weight for semibold
2cd7494
@deezhizyu
Implement ProductCard component
e983f00
@deezhizyu
Add models section on home page
d029deb
@deezhizyu
Fix sizes
ed0580c
@deezhizyu
Add categories section on home page
419089e
@deezhizyu
Add hot prices section on home page
c751bb7
@deezhizyu
Implement old price cross effect
71fe446
@deezhizyu
Implement footer layout
e9457cf
@deezhizyu
Implement Breadcrumbs component
f9230cc
@deezhizyu
Use react-router-dom for navigation
94d5eb6
@deezhizyu
Implement catalog layout
0377025
@deezhizyu
Close dropdown on blur
26cb972
@deezhizyu
Add hover effect on ProductCard
58c4448
@deezhizyu
Add key property
234b75f
@deezhizyu
Fix dropdown onBlur bug
90fcb1e
@deezhizyu
Add index.ts for Breadcrumbs component
2d9de9d
@deezhizyu
Move strikethroughColorDodge to mixins
c94b390
@deezhizyu
Start implementing product page
d8d8618
@deezhizyu
Create ProductSpecs component
0885a38
@deezhizyu
Add specs on product page
9cd5d11
@deezhizyu
Implement product page layout
5963d88
@deezhizyu
Implement favourites page layout
aea88a9
@deezhizyu
Move divider line from Product to typography
8354588
@deezhizyu
Implement cart page layout
3d00875
volodymyr-soltys97
volodymyr-soltys97 suggested changes Jan 19, 2025
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there is no demo link, you need to add demo link to the PR description
image

@deezhizyu deezhizyu closed this Jan 19, 2025
@deezhizyu deezhizyu reopened this Jan 19, 2025
volodymyr-soltys97
volodymyr-soltys97 suggested changes Jan 20, 2025
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
Let's improve your code

  1. Add the topical title and favicon on the page
image
  1. Add hover effects for all clickable elements on the page
image
  1. Add cursor pointer for all clickable elements
image
  1. These elements should be links
image

anastasiiavorobiova
anastasiiavorobiova suggested changes Jan 24, 2025
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Screenshot 2025-01-24 at 13 46 23
Screenshot 2025-01-24 at 13 46 12

  • Consider removing the product from favourites when the user removes the like
  • Screenshot 2025-01-24 at 13 45 52
  • Consider using links here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anastasiiavorobiova anastasiiavorobiova anastasiiavorobiova requested changes

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deezhizyu @volodymyr-soltys97 @anastasiiavorobiova