Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add project #564

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

add project #564

wants to merge 12 commits into from

Conversation

anna-agerone
Copy link

anastasiiavorobiova
anastasiiavorobiova suggested changes Jan 18, 2025
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

  • Screenshot 2025-01-18 at 14 43 34
  • Consider redirecting to the first page if the sorting is changed
  • Screenshot 2025-01-18 at 14 42 02
  • Check quantity here
Screenshot 2025-01-18 at 14 41 47 - The card shouldn't grow so much - Screenshot 2025-01-18 at 14 40 42 - Consider adding a bit bigger gaps between products for large screens

volodymyr-soltys97
volodymyr-soltys97 suggested changes Jan 19, 2025
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
To improve:

  1. Header links should stretch to their full height for easy clicking.
image
  1. Fix gap between these elements, check it on the design
image
  1. Fix the image in slider, check it
image
  1. Check the horizontal padding for the content
image

VitaliyBondarenko1982
VitaliyBondarenko1982 approved these changes Jan 20, 2025
View reviewed changes
Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VitaliyBondarenko1982 VitaliyBondarenko1982 VitaliyBondarenko1982 approved these changes

@anastasiiavorobiova anastasiiavorobiova Awaiting requested review from anastasiiavorobiova

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anna-agerone @VitaliyBondarenko1982 @volodymyr-soltys97 @anastasiiavorobiova