Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #563

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

solution #563

wants to merge 18 commits into from

Conversation

hsvirina
Copy link

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
To improve:

  1. Add a favicon and topical title on the page
image
  1. Add hover effects here
image
  1. Fix position for these buttons, check it on the design
image image
  1. Add transition when the menu appears on the page and need to center links
image

Copy link

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, there are a few comments to fix:

  1. Fix images on ProductDetails page
    image
  2. On tablet there is some strange horizontal scroll, please remove it
    image
  3. Make it possible to redirect to product page on card click instead of doing it only on image click
    image

@hsvirina hsvirina requested a review from vadiimvooo January 17, 2025 21:25
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants