Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #551

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Q1W2E3R4T5Y6U7I8a
Copy link

@Q1W2E3R4T5Y6U7I8a Q1W2E3R4T5Y6U7I8a commented Dec 22, 2024

@Q1W2E3R4T5Y6U7I8a
Copy link
Author

1. But I am usisng kebab-case, dunno why those error here

src/styles/utils/_extends.scss
48:1 ✖ Expected placeholder to be kebab-case scss/percent-placeholder-pattern

src/styles/utils/_mixins.scss
1:1 ✖ Expected mixin name to be kebab-case scss/at-mixin-pattern
7:1 ✖ Expected mixin name to be kebab-case scss/at-mixin-pattern

2. About having h1, it's not important, right, i can use just divs?

  1. App
    should have h1:

    Timed out retrying after 4000ms

    • expected - actual

    -'Brand new modelsHot Prices'
    +'Product Catalog'

    at Context.eval (webpack://react_phone-catalog/./cypress/integration/page.spec.js:7:17)

2.1 Though, because of that, I can't see other tests, how can I make the tests to execute all the tests regardless whether there are not passed tests?

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there is no demo link, also, if you need some help pls feel free on the fe_chat
image

@Q1W2E3R4T5Y6U7I8a
Copy link
Author

https://q1w2e3r4t5y6u7i8a.github.io/react_phone-catalog/

Sorry, here it is, but there is are some changes for some reason in comparisson to what I see on localhost.
-Fonts are different,
-Icons can't be seen,
-Arrows can't be seen

Ho to fix that?

Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Implement responsive styles for each page
    Screenshot 2024-12-26 at 14 56 15
    Screenshot 2024-12-26 at 14 56 55

  • you use icons as background - so place them into src folder.
    Screenshot 2024-12-26 at 15 00 22

  • pay attention on gap between cards in product list page
    Screenshot 2024-12-26 at 14 55 16

Feel free to ask in chat any question - it will be faster...
Git hub only for review ready tasks...

Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Approve.
Just check path to image for some products for favorite page during prepare project for portfolio.
Replace .jpg on .webp will solve it issue.
Screenshot 2024-12-29 at 16 22 57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants