Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #547

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Develop #547

wants to merge 3 commits into from

Conversation

pasha1932
Copy link

@pasha1932 pasha1932 commented Dec 15, 2024

https://pasha1932.github.io/react_phone-catalog/
Можете підсказати як покращити продуктивність сайту, де саме можна використаи react.memo чи хуки, і чомусь зникли картинки й шрифти з папки public,

image
Ось в мене коли запускаю локально то норм, всі картинки й шрифти підключені

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
Let's improve your code

  1. Regarding the images, you need to specify the full path to them on GitHub.

  2. Add favicon and actual title on the page

image
  1. Regarding optimization, these hooks should be used wherever you have calculations or function creation in components.
    https://medium.com/@golmahdi29/react-hooks-usememo-and-usecallback-2a95c69d3986

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants