Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #545

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Develop #545

wants to merge 12 commits into from

Conversation

Poviakalo
Copy link

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
Let's improve your page

  1. Add a favicon and topical title on the page
image
  1. These buttons must be are on the same vertical line
image
  1. Add the your github profile link for all these elements and open them in the new tab
image
  1. Remove scroll when the menu is open
image

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!
To improve:

  1. When swiping, it should be possible to change the image in the slider
image

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
To improve:

  1. Add hover effects for all clickable elements on the page
image image
  1. Check font family everywhere
image
  1. Fix gap between the buttons block and prices
image

@Poviakalo
Copy link
Author

I checked font family, and in my opinion everything is well.

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, the comments from the previous review still not fixed, you need to make a deploy again after your changes. If you need some help feel free in the fe_chat

Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants