Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finished #544

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

finished #544

wants to merge 6 commits into from

Conversation

oskushnir
Copy link

@oskushnir oskushnir commented Dec 8, 2024

Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.
Needs some improvements.

  1. count items in the cart should be a sum counts each cart item
    Screenshot 2024-12-09 at 14 22 58
  2. Add to cart and favorites not works properly in home page.
    See video, click on button not changes nothing.
Screen.Recording.2024-12-09.at.14.24.00.mov

After visit to products list page and go back to home everything works good.
Similar problem on cart and favorite pages. Some time states not update after remove item or other actions.

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
Let's improve your code

  1. Add a favicon on the page
image
  1. Links should stretch to the full height of the header
image
  1. It should be possible to choose more than 10 items
image
  1. These buttons must be are on the same vertical line
image

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
Let's improve your page

  1. Fix background color for the button after clicked
image
  1. Fix gap between the buttons and prices, check it on the design
image
  1. There should be an option to change the image when swiping
image
  1. Add transition when this menu appears on the page and add close icon here
image

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants