-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solution #398
base: master
Are you sure you want to change the base?
solution #398
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the task requirements! 🎉 Your code is well-structured and meets all the core requirements. While there are some suggestions for using template literals to improve readability, these are minor and don't affect the functionality. Keep up the good work and consider these suggestions for future improvements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
||
clickOnLogo() { | ||
return 'Click on the ' + this.header.logo; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using template literals for string concatenation to improve readability: return
Click on the ${this.header.logo};
|
||
clickOnCommentButton() { | ||
return 'Click on the ' + this.commentButton; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using template literals for string concatenation to improve readability: return
Click on the ${this.commentButton};
return 'Click on the ' + this.commentButton; | ||
} | ||
assertPageOpened() { | ||
return 'The ' + this.url + ' is opened'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using template literals for string concatenation to improve readability: return
The ${this.url} is opened;
No description provided.