Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #398

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pushkarskiyrodion
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task requirements! 🎉 Your code is well-structured and meets all the core requirements. While there are some suggestions for using template literals to improve readability, these are minor and don't affect the functionality. Keep up the good work and consider these suggestions for future improvements! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨


clickOnLogo() {
return 'Click on the ' + this.header.logo;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using template literals for string concatenation to improve readability: return Click on the ${this.header.logo};


clickOnCommentButton() {
return 'Click on the ' + this.commentButton;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using template literals for string concatenation to improve readability: return Click on the ${this.commentButton};

return 'Click on the ' + this.commentButton;
}
assertPageOpened() {
return 'The ' + this.url + ' is opened';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using template literals for string concatenation to improve readability: return The ${this.url} is opened;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants