Solution #386
Solution #386
Conversation
There was a problem hiding this comment.
Great job on the implementation! 🎉 The issue with the super() call is minor and doesn't impact the core functionality. Consider revisiting the constructor parameters for clarity in the future. Keep up the good work!
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| }; | ||
|
|
||
| class PageObject { | ||
| constructor(url,header){ |
There was a problem hiding this comment.
The constructor of the PageObject class takes two parameters, 'url' and 'header', but only 'url' is used. If 'header' is not needed, consider removing it from the parameters.
| }; | ||
|
|
||
| class ArticlePage extends PageObject { | ||
| constructor(url, slug) { | ||
| super(url); |
There was a problem hiding this comment.
The super() call in the ArticlePage constructor should pass both 'url' and 'header' if the PageObject constructor requires two arguments. Currently, it only passes 'url', which might lead to unexpected behavior if 'header' is needed.
No description provided.