Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the task is done #291

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Anastasiya145
Copy link

No description provided.

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use Template literals only if you need to put some var or condition in the string

this.slug = slug;
}
get commentButton() {
return `[Publish comment] button`;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return `[Publish comment] button`;
return '[Publish comment] button';

return `[Publish comment] button`;
}
clickOnCommentButton() {
return `Click on the ` + this.commentButton;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return `Click on the ` + this.commentButton;
return `Click on the ${this.commentButton}`;

return `Click on the ` + this.commentButton;
}
assertPageOpened() {
return 'The ' + this.url + ' is opened';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants