-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the task is done #291
base: master
Are you sure you want to change the base?
the task is done #291
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use Template literals only if you need to put some var or condition in the string
src/pageObject.js
Outdated
this.slug = slug; | ||
} | ||
get commentButton() { | ||
return `[Publish comment] button`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return `[Publish comment] button`; | |
return '[Publish comment] button'; |
src/pageObject.js
Outdated
return `[Publish comment] button`; | ||
} | ||
clickOnCommentButton() { | ||
return `Click on the ` + this.commentButton; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return `Click on the ` + this.commentButton; | |
return `Click on the ${this.commentButton}`; |
src/pageObject.js
Outdated
return `Click on the ` + this.commentButton; | ||
} | ||
assertPageOpened() { | ||
return 'The ' + this.url + ' is opened'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.