-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #266
Solution #266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
files deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments
}; | ||
|
||
class ArticlePage extends PageObject { | ||
|
||
get commentButton() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add constructor before get commentButton()
constructor(url, slag) {
super(url);
this.url = url + ${slag}
;
};
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests don't run after adding. Why we need to add this constructor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
task description - ArticlePage constructor takes url and slug. Constructor should modify original url by adding slug at the end
}; | ||
|
||
class PageObject { | ||
|
||
constructor(url) { | ||
this.url = url; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe you should add URL
like this :
this.url = 'http://test.com';
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
Need small fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check the comments
clickOnLogo() { | ||
return 'Click on the Conduit logo'; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clickOnLogo() { | |
return 'Click on the Conduit logo'; | |
}; | |
clickOnLogo() { | |
return 'Click on the Conduit logo'; | |
}; |
task description - PageObject should contain clickOnLogo method. The method should return a string 'Click on the' + logo from the Header class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't use header class here
}; | ||
|
||
class ArticlePage extends PageObject { | ||
|
||
get commentButton() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
task description - ArticlePage constructor takes url and slug. Constructor should modify original url by adding slug at the end
clickOnCommentButton() { | ||
return 'Click on the [Publish comment] button'; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clickOnCommentButton() { | |
return 'Click on the [Publish comment] button'; | |
}; | |
clickOnCommentButton() { | |
return 'Click on the [Publish comment] button'; | |
}; |
task description - ArticlePage should contain clickOnCommentButton method. The method should return a string 'Click on the' + commentButton
No description provided.