Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #529

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #529

wants to merge 1 commit into from

Conversation

mukutiuk
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on automating the student registration page! 🎉 Your code meets the task requirements and constraints effectively. While there are a couple of minor issues, such as the random number in the 'current address' field and the lack of verification for the date of birth field, these do not significantly impact the overall functionality. Keep up the good work, and consider addressing these points to enhance the reliability of your tests in the future. 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

const name = 'Roma';
const lastName = 'Mykytiuk';
const email = '[email protected]';
const curentAdres = Math.floor(Math.random() * 100);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'current address' is being filled with a random number, which might not be ideal for testing purposes. Consider using a consistent address format to ensure reliable test results.

cy.get('#userEmail').type(email);
cy.get('[for="gender-radio-1"]').click();
cy.get('#userNumber').type('123456789');
cy.get('#dateOfBirthInput').type('{enter}');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The date of birth field is being submitted without any specific value. Consider setting a specific date to ensure the field is filled correctly and to verify its functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants