-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solution #527
base: master
Are you sure you want to change the base?
solution #527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on setting up the Cypress tests and configuration! 🎉 The code meets the task requirements, and the form automation works well. Just a small suggestion: consider refining the subject
field generation to ensure it aligns with expected input formats. Keep up the good work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
const { generateRegistrationInput } = | ||
require('../support/generateRegistrationInput'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The import statement for generateRegistrationInput
is correct, but ensure that the path is accurate relative to the file structure. It seems correct based on the provided context.
subject | ||
} = generateRegistrationInput(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The subject
field is generated using faker.lorem.sentences().slice(2, 11)
, which might not produce a valid subject input for the form. Consider using a more appropriate method to generate a single subject name or keyword.
const email = faker.internet.email(); | ||
const number = '0981324564'; | ||
const address = faker.location.streetAddress(); | ||
const subject = faker.lorem.sentences().slice(2, 11); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The subject
field is generated using faker.lorem.sentences().slice(2, 11)
, which might not produce a valid subject input for the form. Consider using a more appropriate method to generate a single subject name or keyword, such as faker.lorem.word()
or a predefined list of subjects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accepted, well done
No description provided.