Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #527

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

DemianZolotukhin
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on setting up the Cypress tests and configuration! 🎉 The code meets the task requirements, and the form automation works well. Just a small suggestion: consider refining the subject field generation to ensure it aligns with expected input formats. Keep up the good work! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +2 to +3
const { generateRegistrationInput } =
require('../support/generateRegistrationInput');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import statement for generateRegistrationInput is correct, but ensure that the path is accurate relative to the file structure. It seems correct based on the provided context.

Comment on lines +16 to +17
subject
} = generateRegistrationInput();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The subject field is generated using faker.lorem.sentences().slice(2, 11), which might not produce a valid subject input for the form. Consider using a more appropriate method to generate a single subject name or keyword.

const email = faker.internet.email();
const number = '0981324564';
const address = faker.location.streetAddress();
const subject = faker.lorem.sentences().slice(2, 11);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The subject field is generated using faker.lorem.sentences().slice(2, 11), which might not produce a valid subject input for the form. Consider using a more appropriate method to generate a single subject name or keyword, such as faker.lorem.word() or a predefined list of subjects.

Copy link

@4ksandrey 4ksandrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted, well done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants