-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #813
base: master
Are you sure you want to change the base?
Solution #813
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work on this project! 😊 While your implementation is mostly aligned with the task requirements, there's a critical issue that needs to be addressed before we can approve the pull request. The typo in the variable name objctToReturn
should be corrected to objectToReturn
. This change is important to ensure consistency and prevent any potential confusion or errors in the code. Once this is fixed, your solution should work as expected. Keep up the great work, and I look forward to seeing the updated version! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
src/createServer.js
Outdated
|
||
const text = convertToCase(PATH, toCase.toUpperCase()); | ||
|
||
const objctToReturn = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the variable name objctToReturn
. It should be objectToReturn
to maintain consistency and avoid potential confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on correcting the typo and ensuring the variable objectToReturn
is correctly named! 🎉 Your implementation meets the task requirements and constraints, effectively handling text case conversion with proper input validation and error messaging. However, there's a critical issue to address: ensure the convertToCase
function returns an object with originalCase
and convertedText
properties as expected. This is crucial for the functionality of your code.
While your solution is approved to help you move forward, please review the comments and address the critical issue in future iterations to enhance your code quality. Keep up the good work and continue learning from these experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
No description provided.